Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_install_media_detect: Kernel info files in download basket incorrectly counted as kernel duplicates #703

Closed
rob0d opened this issue Apr 12, 2024 · 1 comment
Assignees

Comments

@rob0d
Copy link
Contributor

rob0d commented Apr 12, 2024

As discussed with @berndfinger, when SAP Download Manager is used to download the basket, it will download the actual files as well as info files for most SAR file with the same name, but no suffix:

ls SAPEXE*
SAPEXE_51-70007807      SAPEXEDB_51-70007806
SAPEXE_51-70007807.SAR  SAPEXEDB_51-70007806.SAR

These files are correctly detected by the sapfile script:

# ./sapfile  -e --lsar_file=/usr/bin/unrar --sapcar_file=/install/s4hana/2023sp01/SAPCAR.EXE /install/s4hana/2023sp01/SAPEXE_51-70007807.SAR
/install/s4hana/2023sp01/SAPEXE_51-70007807.SAR;sap_kernel;sap_swpm_download_basket;none;sapcar;n;n
# ./sapfile  -e --lsar_file=/usr/bin/unrar --sapcar_file=/install/s4hana/2023sp01/SAPCAR.EXE /install/s4hana/2023sp01/SAPEXE_51-70007807
/install/s4hana/2023sp01/SAPEXE_51-70007807;sap_kernel;sap_swpm_download_basket;none;other;n;n

However the code that checks for duplicates in roles/sap_install_media_detect/tasks/prepare/create_file_list_phase_2.yml e.g.

  • name: SAP Install Media Detect - Prepare - Assert that exactly one SAP Kernel DB independent is present
    does not take this into account.

Pull request was created with fixed for SAPEXE, SAPEXEDB, igs, igshelper and WebDispl.
I have not tested all options as I only have S/4 HANA installation, so I am not sure if similar fix will be needed for other file types.

@sean-freeman sean-freeman changed the title Kernel info files in download basket incorrectly counted as kernel duplicates sap_install_media_detect: Kernel info files in download basket incorrectly counted as kernel duplicates Apr 12, 2024
@berndfinger berndfinger self-assigned this May 3, 2024
@berndfinger
Copy link
Member

Fixed in #702 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants