Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_install_media_detect: Detection of duplicate SAR files for EXE, EXEDB, igs, igshelper and webdisp should count only file with type=sapcar #702

Merged
merged 1 commit into from
May 3, 2024

Conversation

rob0d
Copy link
Contributor

@rob0d rob0d commented Apr 12, 2024

This is a fix for issue #703

…ebdisp should count only file with type=sapcar
@sean-freeman sean-freeman changed the title Detection of duplicate SAR files for EXE, EXEDB, igs, igshelper and webdisp should count only file with type=sapcar sap_install_media_detect: Detection of duplicate SAR files for EXE, EXEDB, igs, igshelper and webdisp should count only file with type=sapcar Apr 12, 2024
@berndfinger berndfinger self-requested a review May 3, 2024 14:45
@berndfinger
Copy link
Member

I tested a download directory with S/4HANA Foundation 2022 with:

  • SAPEXE_201-70006642.SAR
  • SAPEXEDB_201-70006641.SAR
  • igsexe_4-70005417.sar
  • igshelper_17-10010245.sar
    and some four dummy text files with the same prefix but without the suffix (e.g. SAPEXE_201-70006642).
    When using the dev tree with the proposed change in this PR, the role finished with the expected entries for sap_swpm_igs_file_name, sap_swpm_igs_helper_file_name, sap_swpm_kernel_dependent_file_name, and sap_swpm_kernel_independent_file_name.
    When using the current dev tree, the role fails (as described in sap_install_media_detect: Kernel info files in download basket incorrectly counted as kernel duplicates #703) with:
  assertion: __sap_install_media_detect_fact_files_sapfile_results | selectattr('file', 'search', 'SAPEXE_') | length == 1
  evaluated_to: false
  msg: No, or more than one, DB independent SAP Kernel file found

When using the dev tree but without the four dummy text files, the resulting outputs of task Test result for 'sap_s4hana_foundation_2022': Display _result_dict are identical.

---> PASS

Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berndfinger berndfinger merged commit d10461c into sap-linuxlab:dev May 3, 2024
3 of 4 checks passed
@rob0d rob0d deleted the patch-1 branch May 4, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants