-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sap_netweaver_preconfigure-RHEL: Sync with SAP note 3119751 v.13 #686
Conversation
Solves sap-linuxlab#685 for the normal mode of the role Signed-off-by: Bernd Finger <bfinger@redhat.com>
Solves sap-linuxlab#685 for the assert mode of the role Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#685. Signed-off-by: Bernd Finger <bfinger@redhat.com>
roles/sap_netweaver_preconfigure/tasks/sapnote/assert-3119751.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments from Janine, as it is good practise to avoid shell/command module
@ja9fuchs Thanks, good point! |
Implements the suggestion in the PR sap-linuxlab#686 for the normal mode. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#685. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Implements the suggestion in the PR sap-linuxlab#686 for the assert mode. Also modifies some task names. Relates to sap-linuxlab#685. Signed-off-by: Bernd Finger <bfinger@redhat.com>
roles/sap_netweaver_preconfigure/tasks/sapnote/assert-3119751.yml
Outdated
Show resolved
Hide resolved
Also replace looping over a dict by using the map filter, as suggested in the code review. Relates to sap-linuxlab#685. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#685. Signed-off-by: Bernd Finger <bfinger@redhat.com>
roles/sap_netweaver_preconfigure/tasks/sapnote/assert-3119751.yml
Outdated
Show resolved
Hide resolved
roles/sap_netweaver_preconfigure/tasks/sapnote/assert-3119751.yml
Outdated
Show resolved
Hide resolved
Relates to sap-linuxlab#685. Signed-off-by: Bernd Finger <bfinger@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 😺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We need to sync the role
sap_netweaver_preconfigure
with the latest status of SAP note 3119751:For RHEL 8, the following needs to be done to be prepared for all SAP kernels which are supported on RHEL 8 so that the SAP kernel can find the GCC10 symbols:
/opt/rh/SAP/lib64
(the directory where the shared libraries of thecompat-sap-c++-<version>
package(s) are placed), a symlink namedlibstdc++.so.6
needs to be present, pointing to filecompat-sap-c++-<version>.so
in the same directory, with<version>
being10
or higher./usr/sap/lib
, namedlibstdc++.so.6
and pointing to file/opt/rh/SAP/lib64/libstdc++.so.6
. This is becauseRPATH
for older kernels did not yet include/opt/rh/SAP/lib64
.For simplicity, maintainability and supportability, we always create both links for RHEL 8.