Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_netweaver_preconfigure-RHEL: Sync with SAP note 3119751 v.13 #686

Merged
merged 9 commits into from
Mar 20, 2024

Conversation

berndfinger
Copy link
Member

We need to sync the role sap_netweaver_preconfigure with the latest status of SAP note 3119751:

For RHEL 8, the following needs to be done to be prepared for all SAP kernels which are supported on RHEL 8 so that the SAP kernel can find the GCC10 symbols:

  • In directory /opt/rh/SAP/lib64 (the directory where the shared libraries of the compat-sap-c++-<version> package(s) are placed), a symlink named libstdc++.so.6 needs to be present, pointing to file compat-sap-c++-<version>.so in the same directory, with <version> being 10 or higher.
  • For certain older versions of the SAP kernel, there needs to be an additional symlink in directory /usr/sap/lib, named libstdc++.so.6 and pointing to file /opt/rh/SAP/lib64/libstdc++.so.6. This is because RPATH for older kernels did not yet include /opt/rh/SAP/lib64.

For simplicity, maintainability and supportability, we always create both links for RHEL 8.

Solves sap-linuxlab#685 for the normal mode of the role

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Solves sap-linuxlab#685 for the assert mode of the role

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#685.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Copy link
Member

@rhmk rhmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments from Janine, as it is good practise to avoid shell/command module

@berndfinger
Copy link
Member Author

@ja9fuchs Thanks, good point!

Implements the suggestion in the PR sap-linuxlab#686 for the normal mode.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#685.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Implements the suggestion in the PR sap-linuxlab#686 for the assert mode.
Also modifies some task names.

Relates to sap-linuxlab#685.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
@ja9fuchs ja9fuchs self-requested a review March 19, 2024 15:43
Also replace looping over a dict by using the map filter, as suggested in
the code review.

Relates to sap-linuxlab#685.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#685.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#685.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 😺

Copy link
Member

@rhmk rhmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhmk rhmk merged commit 0821135 into sap-linuxlab:dev Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants