sap_general_preconfigure: Fix /etc/hosts check in assert mode #697
Conversation
Solves issue sap-linuxlab#696. Signed-off-by: Bernd Finger <bfinger@redhat.com>
| @@ -20,17 +20,18 @@ | |||
| success_msg: "PASS: The line '{{ sap_general_preconfigure_ip }} {{ sap_general_preconfigure_hostname }}.{{ sap_general_preconfigure_domain }} {{ sap_general_preconfigure_hostname }}' is once in /etc/hosts." | |||
| ignore_errors: "{{ sap_general_preconfigure_assert_ignore_errors | d(false) }}" | |||
|
|
|||
| # We allow more than one line containing sap_general_preconfigure_ip: | |||
There was a problem hiding this comment.
Why though? Only the first entry is used. If duplicate entries of the same IP are present it will most likely lead to trouble later and should be reported as a failure.
It's not a healthy configuration to continue the setup with.
| register: __sap_general_preconfigure_register_sap_ip_once_assert | ||
| ignore_errors: yes | ||
| changed_when: no | ||
|
|
||
| - name: Assert that there is just one line containing {{ sap_general_preconfigure_ip }} in /etc/hosts | ||
| - name: Assert that there is at least one line containing {{ sap_general_preconfigure_ip }} in /etc/hosts |
There was a problem hiding this comment.
As a sysadmin, I would not allow PASS-ing this check if one IP is configured more than once in /etc/hosts.
There was a problem hiding this comment.
We currently allow more than one line with the same IP address in /etc/hosts in
, so we now should discuss the impact of allowing such a configuration in a broader context.
There was a problem hiding this comment.
Hi,
IIRC this was a user request. This user is putting host aliases to separate lines instead of appending to a single line. This was in the very beginning and I am not sure if this has been documented properly.
So I am fine with approving this PR and wait for complaints. Especially because I haven't found any evidence, that this is a common practise in the net.
|
After the reply from @rhmk , let's no longer allow more than one line containing the same IPv4 address in /etc/hosts. This also affects the role |
…address Relates to sap-linuxlab#696. Signed-off-by: Bernd Finger <bfinger@redhat.com>
This speeds up processing and as a side effect reduces the number of programming languages. Relates to sap-linuxlab#696. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#696. Signed-off-by: Bernd Finger <bfinger@redhat.com>
... for triggering modified github workflows Signed-off-by: Bernd Finger <bfinger@redhat.com>
Solves issue sap-linuxlab#736. It's essentially a backout of PR sap-linuxlab#697, especially of commit 1fc1459. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Solves issue #696.