neutron: Add ability to specify agent_boot_time #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With L2pop, when the first port on a node gets active, or when the agent is still starting (uptime of agent < agent_boot_time), then a full sync of the L2pop for that network is done. The sync therefore does not happen if there are more than one port on the node (like dhcp + router) and if the agent gets the port notification after start+agent_boot_time. The first condition can occur fairly easily, and the second definitely happens when the cloud is large and/or on boot (because the l3 agent and the dhcp agent are start after the ovs agent, and sometimes the addition of the ports can hence happen long after ovs agent has started). Closes sap-oc#36
|
For the record, patch for master: crowbar#962 |
matelakat
suggested changes
May 11, 2017
| @@ -224,7 +224,8 @@ | |||
| vxlan_end: vni_end, | |||
| vxlan_mcast_group: node[:neutron][:vxlan][:multicast_group], | |||
| external_networks: physnets, | |||
| mtu_value: mtu_value | |||
| mtu_value: mtu_value, | |||
| l2pop_settings: node[:neutron][:l2pop] | |||
There was a problem hiding this comment.
I prefer not to pass down the whole hash, just the value. This way we are exposing the internal structure of l2pop for the template.
No, the new attributes are marked as "not required", so no migration is needed in that case (which is nice here, because we don't need to diverge from Cloud 6 in terms of revisions) |
tpatzig
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With L2pop, when the first port on a node gets active, or when the agent
is still starting (uptime of agent < agent_boot_time), then a full sync
of the L2pop for that network is done.
The sync therefore does not happen if there are more than one port on
the node (like dhcp + router) and if the agent gets the port
notification after start+agent_boot_time.
The first condition can occur fairly easily, and the second definitely
happens when the cloud is large and/or on boot (because the l3 agent
and the dhcp agent are start after the ovs agent, and sometimes the
addition of the ports can hence happen long after ovs agent has
started).
Closes #36