Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation/unit test POC #30

Closed
droshev opened this issue Oct 27, 2018 · 2 comments
Closed

automation/unit test POC #30

droshev opened this issue Oct 27, 2018 · 2 comments
Assignees
Labels
help wanted Extra attention is needed
Projects

Comments

@droshev
Copy link
Contributor

droshev commented Oct 27, 2018

Create a strategy for automation/unit tests per components

@droshev droshev added the help wanted Extra attention is needed label Oct 27, 2018
@droshev droshev added this to To do in Development via automation Oct 27, 2018
@chrismanciero
Copy link
Contributor

chrismanciero commented Nov 9, 2018

@droshev - I started looking into unit testing components with Jest and Enzyme. I create a feature branch (https://github.com/SAP/fundamental-react/tree/unit-testing) which has my unit tests for the MultiInput component and SearchInput controls (both are now at 100% code coverage).

Running npm test:
screen shot 2018-11-10 at 8 58 07 pm

Running npm test -- --coverage will give a code coverage report.

I removed the App.test.js file as well as configured the jest setting in the package.json file to only run the coverage report on the Components .js not on the .Component.js file since those files are the implementation of the components and I don't think are necessary to be tested.
screen shot 2018-11-10 at 9 00 54 pm

@chrismanciero
Copy link
Contributor

@droshev @InnaAtanasova Should this story be closed since all components have unit test and we have the automated tests setup with the builds?

Development automation moved this from In progress to Done Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
No open projects
Development
  
Done
Development

No branches or pull requests

3 participants