Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang version check fails for some tags #16

Closed
rabdill opened this issue Dec 6, 2017 · 1 comment
Closed

Golang version check fails for some tags #16

rabdill opened this issue Dec 6, 2017 · 1 comment
Labels

Comments

@rabdill
Copy link

rabdill commented Dec 6, 2017

Encountered this when the go-hdb was pulled in as a subdependency and started panicking during our app's testing when we upgraded from 0.9.2 to 0.9.4. In short, it looks like the Go version check added to driver/runtime.go expects the releases of Golang to use semantic versioning, when they don't. It's checking to make sure there are three parts—major, minor and patch—but for people running the Aug. 24 release (c8aec40), called only "go1.9", this check fails. I'm assuming similar behavior would pop up with other releases such as go1.9beta2.

@stfnmllr stfnmllr added the bug label Dec 7, 2017
@stfnmllr
Copy link
Contributor

stfnmllr commented Dec 7, 2017

fixed with release 0.9.5

@stfnmllr stfnmllr closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants