Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigation node as a link to an external page #91

Closed
hardl opened this issue Sep 19, 2018 · 4 comments
Closed

navigation node as a link to an external page #91

hardl opened this issue Sep 19, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@hardl
Copy link
Contributor

hardl commented Sep 19, 2018 •
edited by kwiatekus
Loading

Introduce a static link node that only has the properties

  • label
  • category
  • externalLinkUrl
  • sameWindow

If a node has a property externalLinkUrl, it is treated as a static link node and all irrelevant properties should be ignored. In the left-side navigation, these nodes should get a dedicated styleclass so they can be later distinguished visually.
@hardl hardl added this to the Sprint_Swinka_1 milestone Sep 19, 2018
@hardl hardl added area/luigi enhancement New feature or request labels Sep 19, 2018
@kwiatekus kwiatekus modified the milestones: Sprint_Swinka_1, Backlog_Swinka Sep 19, 2018
@hardl hardl modified the milestones: Backlog_Swinka, Sprint_Swinka_1 Oct 2, 2018
@parostatkiem-zz parostatkiem-zz self-assigned this Oct 2, 2018
@parostatkiem-zz
Copy link
Contributor

parostatkiem-zz commented Oct 2, 2018 •
edited
Loading

I have a question about sameWindow property. If true, it should show external website inside our <iframe>. If false, it should open new tab in browser and go to the external website. Am I right?

@dariadomagala-sap
Copy link
Contributor

@parostatkiem AFAIK if it's set to true we should open the external page in the same tab, but not as an iFrame. We already have an option to put it inside iFrame, this is a different functionality - here we want to leave Luigi completely.

@parostatkiem-zz
Copy link
Contributor

It's even simplier!

@hardl
Copy link
Contributor Author

hardl commented Oct 2, 2018

It's exactly like Daria said ;)
And default should be "false".

@parostatkiem-zz parostatkiem-zz mentioned this issue Oct 2, 2018
Merged
@kwiatekus kwiatekus modified the milestones: Sprint_Swinka_1, Sprint_Swinka_2 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kwiatekus @hardl @parostatkiem-zz @dariadomagala-sap