controller: delete timeseries after cleanup

sapcc · Aug 26, 2020 · 8c6aa21 · 8c6aa21
1 parent 0d59235
commit 8c6aa21
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/internal/controller/cleanup.go b/internal/controller/cleanup.go
@@ -87,6 +87,7 @@ func (c *Controller) cleanUpOrphanedAbsentAlertsCluster() error {
 				if err := c.cleanUpOrphanedAbsentAlerts(n, aPR); err != nil {
 					return err
 				}
+				c.metrics.SuccessfulPrometheusRuleReconcileTime.DeleteLabelValues(namespace, n)
 			}
 		}
 	}

diff --git a/internal/controller/controller.go b/internal/controller/controller.go
@@ -316,6 +316,9 @@ func (c *Controller) syncHandler(key string) error {
 		// orphaned absent alerts.
 		c.logger.Debug("msg", "PrometheusRule no longer exists", "key", key)
 		err = c.cleanUpOrphanedAbsentAlertsNamespace(name, namespace)
+		if err == nil {
+			c.metrics.SuccessfulPrometheusRuleReconcileTime.DeleteLabelValues(namespace, name)
+		}
 	default:
 		// Requeue object for later processing.
 		return err