Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to gophercloud2 #138

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Upgrade to gophercloud2 #138

merged 1 commit into from
Jul 8, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jul 1, 2024 •
edited
Loading

TODO:

  • adapt the changed error interface in our methods, too

Nuckal777
Nuckal777 reviewed Jul 2, 2024
View reviewed changes
gopherpolicy/pkg.go Outdated Show resolved Hide resolved
majewsky
majewsky requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of throwing away the Require method?

mock/validator_test.go Outdated Show resolved Hide resolved
majewsky
majewsky approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We clarified the misunderstanding that led to the second commit in a direct conversation. The first commit is enough.

@majewsky majewsky merged commit c3fa837 into master Jul 8, 2024
10 checks passed
@majewsky majewsky deleted the gophercloud2 branch July 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuckal777 Nuckal777 Nuckal777 left review comments

@majewsky majewsky majewsky approved these changes

@VoigtS VoigtS Awaiting requested review from VoigtS VoigtS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @majewsky @Nuckal777