Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/thanos: set default user to 0 (root) #5855

Merged
merged 1 commit into from Jan 4, 2024

Conversation

richardtief
Copy link
Contributor

The upstream Thanos image has changed the default user in the container image to 1001 instead of 0 (root).

thanos-io/thanos#6107

As we are dependent on user 0 in our environment, we explicitly set it to 0.

The upstream Thanos image has changed the default user in the container image to 1001 instead of 0 (root).

thanos-io/thanos#6107

As we are dependent on user 0 in our environment, we explicitly set it to 0.
Copy link
Contributor

@viennaa viennaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, security wise not great, but the existing files are root owned, so we go for it.

@viennaa viennaa merged commit 36b0fe9 into master Jan 4, 2024
3 checks passed
@joker-at-work joker-at-work deleted the set-thanos-default-permissions branch March 12, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants