Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CADF Support #26

Merged
merged 16 commits into from
Dec 22, 2017
Merged

Improve CADF Support #26

merged 16 commits into from
Dec 22, 2017

Conversation

jobrs
Copy link
Contributor

@jobrs jobrs commented Dec 22, 2017 •
edited
Loading

  • Support additional CADF event fields as required by openstack-audit-middleware
    • attachments (using typeURI for contentType)
    • Resource addresses and host
    • Resource domain (complementing name with namespace info)
  • Use same type for all resource-like attributes
  • Support OpenStack extension of Resource with project_id/domain_id for initiator and target
  • Additional fixes:
    • requestPath naming fixed (not requestpath)
    • eventTime format uses CADF flavour of ISO8601 for timezone
    • eventType considered in tests
    • host attribute omitted when empty
    • Travis CI config fixed, central build passing now

Joachim Barheine added 16 commits December 22, 2017 11:57
add attachments; consolidate types
563b2ec
fix golint issues
c2cb964
make gocovcat +x
9e1704a
adapt tests
9234b6d
fix eventType, eventTime, attachment type
b27cd82 
* eventType was empty
* eventTime format was pythonic, not CADF
* attachment typeURI attribute renamed from contentType to typeURI
  (because this is what others understood and makes more sense)
fix typeURI lower-case (no json ser)
ac55776
adapt mocks
0fd2072
adapt mocks
b18fb90
fix timezone format
e95af00
fix tests
84fe7a3
fix tests
97778d5
fix tests
93e46df
fix tests
7ffd17c
use typed eventTime
70d1a77
Revert "use typed eventTime"
fbcbd99 
This reverts commit 70d1a77.

Reason: There is no straightforward way to produce ISO8601 format
in the variant expected by CADF. Right now there is no *strong* need to
treat eventTime as a time.Time since we just pass it through.
update docs
4077ef6
@jobrs jobrs merged commit 21d068a into master Dec 22, 2017
@jobrs jobrs deleted the cadf_ext branch December 22, 2017 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jobrs