Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capacity-manila: consider "hardware_state" for capacity counting #332

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

majewsky
Copy link
Contributor

@majewsky majewsky commented Jun 2, 2023

@chuan137 @Carthaca I saw from your meeting minutes that this is appearing in prod now, so I'm getting ready to start using it in Limes. Please let me know when you're done with the rollout.

Checklist:

  • If this PR is about a plugin, I tested the plugin against an OpenStack cluster.
  • I updated the documentation to describe the semantical or interface changes I introduced.

@Carthaca
Copy link
Contributor

Carthaca commented Jun 2, 2023

You are fast 👍 . Yes, I wanted to let you know, once this has been deployed everywhere (most likely Monday).

This is removing the entire pool, which means we don't just drop the capacity, but also the usage, right?
I think it would be good to keep the usage, though. That was agreed with Frank when we brainstormed about that feature. But I'm not sure what is the current agreement: I saw the issue with usable < provisioned coming up in ironic, that in theory could happen here then, as well ...

But in the end, just make CBR happy, please and have a look at consistency across the services :)

@majewsky
Copy link
Contributor Author

majewsky commented Jun 2, 2023

CBR would like to be able to track changes to the set of pools and their hardware_state.

  • add subcapacities for each pool, with capa values split according to the share-snapshot ratio
  • when hardware state indicates to not count capacity, we should still include the respective subcapacity

@coveralls
Copy link

Coverage Status

coverage: 79.56%. remained the same when pulling 335bb99 on manila-hardware-state into cff70be on master.

Copy link
Contributor

@Carthaca Carthaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hardware_state has been deployed to golden regions on Wednesday

@majewsky majewsky merged commit 4ceffb5 into master Jun 9, 2023
10 checks passed
@majewsky majewsky deleted the manila-hardware-state branch June 9, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants