capacity-manila: refactor Scrape() to separate computations per AZ #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majewsky
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
majewsky
changed the title
…parately This does not change the actual numbers that come out. But by handling each AZ entirely separately as soon as possible, the next rewrite will be simpler.
majewsky
force-pushed
the
capacity-manila-refactor
branch
from
ca08d6d
to
159cec5
Compare
SuperSandro2000
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the "manila" capacity plugin. After its rewrite to AZ awareness last year, I never really cleaned up the implementation, so there is a bit of a weird structure where capacity for all AZs is computed in the same function even though the function cleanly factors into separate computations per AZ.
Checklist:
I updated the documentation to describe the semantical or interface changes I introduced.