capacity-manila: consider ResourceDemand when splitting capacity/usage between shares and snapshots #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Nobody is using these subcapacities right now. 2. Having them split like this would make the change in the next commit extremely painful.
majewsky
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
The CapacityBalance is only used for capacity and usage that is not covered by a suitable demand. This got a bit more complicated than I expected because the demand applies to overcommitted capacity, so the demand numbers need to be converted back into the respective raw numbers first.
majewsky
force-pushed
the
capacity-manila-by-demand-2
branch
from
4214588
to
82886ef
Compare
SuperSandro2000
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: