Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maia] Added application credential authentication #61

Merged
merged 39 commits into from
Oct 23, 2019
Merged

[maia] Added application credential authentication #61

merged 39 commits into from
Oct 23, 2019

Conversation

shparker1977
Copy link
Contributor

No description provided.

notque
notque reviewed Sep 12, 2019
View reviewed changes
pkg/cmd/client.go Outdated Show resolved Hide resolved
notque
notque reviewed Sep 12, 2019
View reviewed changes
pkg/cmd/client.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 12, 2019 •
edited
Loading

Coverage Status

Coverage increased (+2.1%) to 59.434% when pulling 239847c on enable-application-credentials into 727458b on master.

jobrs
jobrs suggested changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@jobrs jobrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

pkg/cmd/client.go Show resolved Hide resolved
pkg/keystone/keystone.go Show resolved Hide resolved
pkg/keystone/keystone.go Outdated Show resolved Hide resolved
pkg/keystone/keystone.go Outdated Show resolved Hide resolved
pkg/keystone/keystone.go Show resolved Hide resolved
pkg/keystone/keystone.go Show resolved Hide resolved
pkg/keystone/keystone.go Outdated Show resolved Hide resolved
i81196 and others added 20 commits September 18, 2019 08:58
[maia] Added expansion value for application cred secret
ba70dbb
[maia] Added comment for token cache
7963c1c
[maia] Added documentation for app cred authorization
4f2f271
[maia] Camel Cased app cred vars
9e51432
[maia] Adjusted checks for failed authentication
760ef95
digging deeper into the asServiceUser case
ccd3cf8
Merge branch 'master' of https://github.com/sapcc/maia
6740ef8
Improve documentation (#58)
fc84ad3 
* add details on building Maia
* add link to travis-github tutorial
essential Thanos support (#62)
c3cb746 
* add support for extra federate_url endpoint

* support custom prefixes for Prom/Thanos API

* add unit tests

* add VSCode launch config
Accelerate label values (#60)
95b27ac 
* use range_query instead of series for tenant-aware label/x/values API

outcome:
tested on qa-de-1 and ap-au-1:
* API responsiveness increased overall
* no spikes any more in Maia container memory usage
* moderate increase of CPU spikes in Prometheus when API is called
Merge branch 'master' of https://github.com/sapcc/maia
61a11a6
add test for prometheus driver
7e53e41
add test for prometheus driver (#63)
fcb496d
Merge branch 'master' of https://github.com/sapcc/maia
eefad48
remove Golang 1.11 build
98eb7ba
improve docs (#64)
c61fe8e 
* improve docs

* formatting
[maia] Added application credential authentication
369b9d4
[maia] Fixed typo
73c219b
[maia] Adjust logic for linting
4b0716a
[maia] Added tests and fixed logic
7a5696b
i81196 and others added 14 commits October 15, 2019 10:05
@jobrs jobrs requested review from jobrs, notque and thgrs and removed request for jobrs October 16, 2019 11:32
thgrs
thgrs approved these changes Oct 23, 2019
View reviewed changes
Copy link

@thgrs thgrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thgrs thgrs merged commit ac1c1a0 into master Oct 23, 2019
@thgrs thgrs deleted the enable-application-credentials branch October 23, 2019 14:26
@jobrs jobrs mentioned this pull request Oct 25, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobrs jobrs jobrs approved these changes

@thgrs thgrs thgrs approved these changes

@notque notque Awaiting requested review from notque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shparker1977 @coveralls @notque @jobrs @thgrs