Fix delay clone split when creating share from snapshot #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuan137
changed the title
Carthaca
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Looking at c05497c...sapcc:manila:fix-delay-clone-split helped me to better understand what has changed now in total
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to delay split clone to avoid "Volume busy" errors. However, previous fix dd13d5a does not work properly, see the issue #118. This is also a rework of #117, which follows the fix and did not consider that
splitargument should take precedence over thesplitfield inprovisioning_options.