Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing metrics #25

Closed
lindhor opened this issue May 27, 2022 · 1 comment · Fixed by #26
Closed

Missing metrics #25

lindhor opened this issue May 27, 2022 · 1 comment · Fixed by #26

Comments

@lindhor
Copy link
Contributor

lindhor commented May 27, 2022

I wonder if you would consider adding additional metrics to closer match what the node_exporter provide. If I understand your codebase correctly you already get additional values back from the ntp server part of the Query response. I.e. these values (and node_exporters corresponding metric in parentheses)

  • RTT (node_ntp_rtt)
  • ReferenceTime (node_ntp_reference_timestamp_seconds)
  • RootDelay (node_ntp_root_delay)
  • RootDispersion (node_ntp_root_dispersion)
  • Leap (node_ntp_leap)

You might also want to add

  • Precision
  • KissCode (as a label)

I also would like to say I really like your approach of being able to remotely "blackbox like" poll ntp servers. That is very useful and a great feature compared to node_exporter. It is also a big benefit that ntp_exporter runs on different OS:es compared to node_exporter only on Unix-like ones.

@majewsky
Copy link
Contributor

majewsky commented May 30, 2022

The current set of metrics does what we need it to do, so we don't plan on extending it ourselves. But if you (or anyone else) wants to send a PR, we will certainly look at it.

lindhor added a commit to lindhor/ntp_exporter that referenced this issue May 30, 2022
Add metrics similar to node_exporter. I.e. rtt, reference time, root delay/dispersion/distance, precision and leap second indicator.

closes sapcc#25
lindhor added a commit to lindhor/ntp_exporter that referenced this issue May 31, 2022
Add metrics similar to node_exporter. I.e. rtt, reference time, root delay/dispersion/distance, precision and leap second indicator.

closes sapcc#25
lindhor added a commit to lindhor/ntp_exporter that referenced this issue Jun 3, 2022
Add metrics similar to node_exporter. I.e. rtt, reference time, root delay/dispersion/distance, precision and leap second indicator.

closes sapcc#25
lindhor added a commit to lindhor/ntp_exporter that referenced this issue Jun 3, 2022
Add metrics similar to node_exporter. I.e. rtt, reference time, root delay/dispersion/distance, precision and leap second indicator.

closes sapcc#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants