New API #5
Merged
New API #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE:
* Rename `minWidth` prop to `minColumnWidth` to avoid clash with styled-system `minWidth` prop.
* Remove `gap` prop, use `gridGap`, `gridRowGap` and `gridColumnGap`: use standard styled-system prop and allow different gaps between rows and columns.
* No default 8px gap.
* Use spacing scale in `minColumnWidth`, so `minColumnWidth={7}` now adds 256px min column width.
Closes #2 #3 #4
sapegin
pushed a commit
that referenced
this pull request
Jul 24, 2019
## New API Closes ([#5](#5)), closes [#2](#2) [#3](#3) [#4](#4) ### Breaking changes * Rename `minWidth` prop to `minColumnWidth` to avoid clash with styled-system `minWidth` prop. * Remove `gap` prop, use `gridGap`, `gridRowGap` and `gridColumnGap`: use standard styled-system prop and allow different gaps between rows and columns. * No default 8px gap. * Use spacing scale in `minColumnWidth`, so `minColumnWidth={7}` now adds 256px min column width.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
minWidthprop tominColumnWidthto avoid clash with styled-systemminWidthprop.gapprop, usegridGap,gridRowGapandgridColumnGap: use standard styled-system prop and allow different gaps between rows and columns.minColumnWidth, sominColumnWidth={7}now adds 256px min column width.Closes #2 #3 #4