Revert "Fix paperjs#769: Implement Item#selection flags to separate s…

…election from item and bounds."

This reverts commit f0edcd3.

# Conflicts:
#	src/path/Segment.js

src/basic/Rectangle.js

@@ -904,13 +904,18 @@ new function() {
              * @default false
              */
             isSelected: function() {
-                return !!(this._owner._selection & /*#=*/ItemSelection.BOUNDS);
+                return this._owner._boundsSelected;
             },
 
             setSelected: function(selected) {
                 var owner = this._owner;
-                if (owner.changeSelection) {
-                    owner.changeSelection(/*#=*/ItemSelection.BOUNDS, selected);
+                if (owner.setSelected) {
+                    owner._boundsSelected = selected;
+                    // Update the owner's selected state too, so the bounds
+                    // actually get drawn. When deselecting, take a path's
+                    // _segmentSelection into account too, since it will
+                    // have to remain selected even when bounds are deselected
+                    owner.setSelected(selected || owner._segmentSelection > 0);
                 }
             }
         })

src/constants.js

@@ -12,5 +12,4 @@
 
 /*#*/ include('util/Numerical.js');
 /*#*/ include('item/ChangeFlag.js');
-/*#*/ include('item/ItemSelection.js');
 /*#*/ include('path/SegmentSelection.js');

src/item/Item.js

@@ -51,30 +51,22 @@ var Item = Base.extend(Emitter, /** @lends Item# */{
     _applyMatrix: true,
     _canApplyMatrix: true,
     _canScaleStroke: false,
-    _pivot: null,
-    _visible: true,
-    _blendMode: 'normal',
-    _opacity: 1,
-    _locked: false,
-    _guide: false,
-    _clipMask: false,
-    _selection: 0,
     _boundsSelected: false,
     _selectChildren: false,
     // Provide information about fields to be serialized, with their defaults
-    // that can be omitted.
+    // that can be ommited.
     _serializeFields: {
         name: null,
         applyMatrix: null,
         matrix: new Matrix(),
         pivot: null,
+        locked: false,
         visible: true,
         blendMode: 'normal',
         opacity: 1,
-        locked: false,
         guide: false,
-        clipMask: false,
         selected: false,
+        clipMask: false,
         data: {}
     }
 },
@@ -435,6 +427,7 @@ new function() { // Injection scope for various item event handlers
      * @default false
      * @ignore
      */
+    _locked: false,
 
     /**
      * Specifies whether the item is visible. When set to `false`, the item
@@ -455,6 +448,7 @@ new function() { // Injection scope for various item event handlers
      * // Hide the path:
      * path.visible = false;
      */
+    _visible: true,
 
     /**
      * The blend mode with which the item is composited onto the canvas. Both
@@ -496,6 +490,7 @@ new function() { // Injection scope for various item event handlers
      * // Set the blend mode of circle2:
      * circle2.blendMode = 'multiply';
      */
+    _blendMode: 'normal',
 
     /**
      * The opacity of the item as a value between `0` and `1`.
@@ -523,6 +518,7 @@ new function() { // Injection scope for various item event handlers
      * // Make circle2 50% transparent:
      * circle2.opacity = 0.5;
      */
+    _opacity: 1,
 
     // TODO: Implement guides
     /**
@@ -534,26 +530,7 @@ new function() { // Injection scope for various item event handlers
      * @default true
      * @ignore
      */
-
-    getSelection: function() {
-        return this._selection;
-    },
-
-    setSelection: function(selection) {
-        if (selection !== this._selection) {
-            this._selection = selection;
-            var project = this._project;
-            if (project) {
-                project._updateSelection(this);
-                this._changed(/*#=*/Change.ATTRIBUTE);
-            }
-        }
-    },
-
-    changeSelection: function(flag, selected) {
-        var selection = this._selection;
-        this.setSelection(selected ? selection | flag : selection & ~flag);
-    },
+    _guide: false,
 
     /**
      * Specifies whether the item is selected. This will also return `true` for
@@ -588,29 +565,39 @@ new function() { // Injection scope for various item event handlers
                 if (children[i].isSelected())
                     return true;
         }
-        return !!(this._selection & /*#=*/ItemSelection.ITEM);
+        return this._selected;
     },
 
-    setSelected: function(selected) {
-        if (this._selectChildren) {
+    setSelected: function(selected, noChildren) {
+        // Don't recursively call #setSelected() if it was called with
+        // noChildren set to true, see #setFullySelected().
+        if (!noChildren && this._selectChildren) {
             var children = this._children;
             for (var i = 0, l = children.length; i < l; i++)
                 children[i].setSelected(selected);
         }
-        this.changeSelection(/*#=*/ItemSelection.ITEM, selected);
+        if ((selected = !!selected) ^ this._selected) {
+            this._selected = selected;
+            var project = this._project;
+            if (project) {
+                project._updateSelection(this);
+                this._changed(/*#=*/Change.ATTRIBUTE);
+            }
+        }
     },
 
+    _selected: false,
+
     isFullySelected: function() {
-        var children = this._children,
-            selected = !!(this._selection & /*#=*/ItemSelection.ITEM);
-        if (children && selected) {
+        var children = this._children;
+        if (children && this._selected) {
             for (var i = 0, l = children.length; i < l; i++)
                 if (!children[i].isFullySelected())
                     return false;
             return true;
         }
         // If there are no children, this is the same as #selected
-        return selected;
+        return this._selected;
     },
 
     setFullySelected: function(selected) {
@@ -619,7 +606,8 @@ new function() { // Injection scope for various item event handlers
             for (var i = 0, l = children.length; i < l; i++)
                 children[i].setFullySelected(selected);
         }
-        this.changeSelection(/*#=*/ItemSelection.ITEM, selected);
+        // Pass true for hidden noChildren argument
+        this.setSelected(selected, true);
     },
 
     /**
@@ -650,6 +638,8 @@ new function() { // Injection scope for various item event handlers
         }
     },
 
+    _clipMask: false,
+
     // TODO: get/setIsolated (print specific feature)
     // TODO: get/setKnockout (print specific feature)
     // TODO: get/setAlphaIsShape
@@ -790,7 +780,9 @@ new function() { // Injection scope for various item event handlers
         this._pivot = Point.read(arguments, 0, { clone: true, readNull: true });
         // No need for _changed() since the only thing this affects is _position
         this._position = undefined;
-    }
+    },
+
+    _pivot: null,
 }, Base.each({ // Produce getters for bounds properties:
         getStrokeBounds: { stroke: true },
         getHandleBounds: { handle: true },
@@ -1575,9 +1567,9 @@ new function() { // Injection scope for various item event handlers
         // in case #applyMatrix is true.
         this.setApplyMatrix(source._applyMatrix);
         this.setPivot(source._pivot);
-        // Copy over the selection state, use setSelection so the item
-        // is also added to Project#_selectionItems if it is selected.
-        this.setSelection(source._selection);
+        // Copy over the selection state, use setSelected so the item
+        // is also added to Project#selectedItems if it is selected.
+        this.setSelected(source._selected);
         // Copy over data and name as well.
         var data = source._data,
             name = source._name;
@@ -1886,7 +1878,7 @@ new function() { // Injection scope for hit-test functions shared with project
         // See if we should check self (own content), by filtering for type,
         // guides and selected items if that's required.
         var checkSelf = !(options.guides && !this._guide
-                || options.selected && !this.isSelected(true)
+                || options.selected && !this._selected
                 // Support legacy Item#type property to match hyphenated
                 // class-names.
                 || options.type && options.type !== Base.hyphenate(this._class)
@@ -4268,27 +4260,23 @@ new function() { // Injection scope for hit-test functions shared with project
         return updated;
     },
 
-    _drawSelection: function(ctx, matrix, size, selectionItems, updateVersion) {
-        var selection = this._selection,
-            itemSelected = selection & /*#=*/ItemSelection.ITEM,
-            boundsSelected = selection & /*#=*/ItemSelection.BOUNDS
-                    || itemSelected && this._boundsSelected;
-        if (!this._drawSelected)
-            itemSelected = false;
-        if ((itemSelected || boundsSelected) && this._isUpdated(updateVersion)) {
+    _drawSelection: function(ctx, matrix, size, selectedItems, updateVersion) {
+        if ((this._drawSelected || this._boundsSelected)
+                && this._isUpdated(updateVersion)) {
             // Allow definition of selected color on a per item and per
             // layer level, with a fallback to #009dec
             var layer,
-                color = this.getSelectedColor(true) || (layer = this.getLayer())
-                    && layer.getSelectedColor(true),
+                color = this.getSelectedColor(true)
+                    || (layer = this.getLayer()) && layer.getSelectedColor(true),
                 mx = matrix.appended(this.getGlobalMatrix(true));
             ctx.strokeStyle = ctx.fillStyle = color
                     ? color.toCanvasStyle(ctx) : '#009dec';
-            if (itemSelected)
-                this._drawSelected(ctx, mx, selectionItems);
-            if (boundsSelected) {
+            if (this._drawSelected)
+                this._drawSelected(ctx, mx, selectedItems);
+            if (this._boundsSelected) {
                 var half = size / 2,
-                    coords = mx._transformCorners(this.getInternalBounds());
+                    coords = mx._transformCorners(
+                            this.getInternalBounds());
                 // Now draw a rectangle that connects the transformed
                 // bounds corners, and draw the corners.
                 ctx.beginPath();

src/item/Project.js

@@ -62,8 +62,8 @@ var Project = PaperScopeItem.extend(/** @lends Project# */{
         // (e.g. PointText#_getBounds)
         this._view = View.create(this,
                 element || CanvasProvider.getCanvas(1, 1));
-        this._selectionItems = {};
-        this._selectionCount = 0;
+        this._selectedItems = {};
+        this._selectedItemCount = 0;
         // See Item#draw() for an explanation of _updateVersion
         this._updateVersion = 0;
         // Change tracking, not in use for now. Activate once required:
@@ -282,15 +282,15 @@ var Project = PaperScopeItem.extend(/** @lends Project# */{
         // TODO: Return groups if their children are all selected, and filter
         // out their children from the list.
         // TODO: The order of these items should be that of their drawing order.
-        var selectionItems = this._selectionItems,
+        var selectedItems = this._selectedItems,
             items = [];
-        for (var id in selectionItems) {
-            var item = selectionItems[id],
-                selection = item._selection;
-            if (selection & /*#=*/ItemSelection.ITEM && item.isInserted()) {
+        for (var id in selectedItems) {
+            var item = selectedItems[id];
+            if (item.isInserted()) {
                 items.push(item);
-            } else if (!selection) {
-                this._updateSelection(item);
+            } else {
+                this._selectedItemCount--;
+                delete selectedItems[id];
             }
         }
         return items;
@@ -299,15 +299,15 @@ var Project = PaperScopeItem.extend(/** @lends Project# */{
 
     _updateSelection: function(item) {
         var id = item._id,
-            selectionItems = this._selectionItems;
-        if (item._selection) {
-            if (selectionItems[id] !== item) {
-                this._selectionCount++;
-                selectionItems[id] = item;
+            selectedItems = this._selectedItems;
+        if (item._selected) {
+            if (selectedItems[id] !== item) {
+                this._selectedItemCount++;
+                selectedItems[id] = item;
             }
-        } else if (selectionItems[id] === item) {
-            this._selectionCount--;
-            delete selectionItems[id];
+        } else if (selectedItems[id] === item) {
+            this._selectedItemCount--;
+            delete selectedItems[id];
         }
     },
 
@@ -324,9 +324,9 @@ var Project = PaperScopeItem.extend(/** @lends Project# */{
      * Deselects all selected items in the project.
      */
     deselectAll: function() {
-        var selectionItems = this._selectionItems;
-        for (var i in selectionItems)
-            selectionItems[i].setFullySelected(false);
+        var selectedItems = this._selectedItems;
+        for (var i in selectedItems)
+            selectedItems[i].setFullySelected(false);
     },
 
     /**
@@ -868,10 +868,10 @@ var Project = PaperScopeItem.extend(/** @lends Project# */{
         ctx.restore();
 
         // Draw the selection of the selected items in the project:
-        if (this._selectionCount > 0) {
+        if (this._selectedItemCount > 0) {
             ctx.save();
             ctx.strokeWidth = 1;
-            var items = this._selectionItems,
+            var items = this._selectedItems,
                 size = this._scope.settings.handleSize,
                 version = this._updateVersion;
             for (var id in items) {

src/path/CompoundPath.js

@@ -293,14 +293,14 @@ var CompoundPath = PathItem.extend(/** @lends CompoundPath# */{
         }
     },
 
-    _drawSelected: function(ctx, matrix, selectionItems) {
+    _drawSelected: function(ctx, matrix, selectedItems) {
         var children = this._children;
         for (var i = 0, l = children.length; i < l; i++) {
             var child = children[i],
                 mx = child._matrix;
             // Do not draw this child now if it's separately marked as selected,
             // as it would be drawn twice otherwise.
-            if (!selectionItems[child._id]) {
+            if (!selectedItems[child._id]) {
                 child._drawSelected(ctx, mx.isIdentity() ? matrix
                         : matrix.appended(mx));
             }