Skip to content

Experimental Ordinals Support #557

Experimental Ordinals Support

Experimental Ordinals Support #557

Triggered via pull request January 21, 2024 06:43
Status Failure
Total duration 3m 8s
Artifacts

rust.yml

on: pull_request
Matrix: Nightly - ASan + Bench
Matrix: Tests
Matrix: Nightly - Docs / WebAssembly Build + Tests
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 161 warnings
Rustfmt
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
mismatched types: cli/src/contracts/request.rs#L291
error[E0308]: mismatched types --> cli/src/contracts/request.rs:291:17 | 285 | let ctx = Context::new( | ------------ arguments to this function are incorrect ... 291 | ordinals_info | ^^^^^^^^^^^^^ expected `Option<OrdinalsInfo>`, found `Option<Vec<(u64, u64)>>` | = note: expected enum `std::option::Option<sapio_wasm_plugin::OrdinalsInfo>` found enum `std::option::Option<std::vec::Vec<(u64, u64)>>` note: associated function defined here --> /home/runner/work/sapio/sapio/sapio/src/contract/context.rs:66:12 | 66 | pub fn new( | ^^^
clippy_check
Clippy had exited with the 101 exit code
Nightly - ASan + Bench (nightly)
Process completed with exit code 101.
Tests (stable)
Process completed with exit code 101.
Tests (1.75.0)
Process completed with exit code 101.
Tests (beta)
The operation was canceled.
Nightly - Docs / WebAssembly Build + Tests (nightly)
Process completed with exit code 101.
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
unused import: `Write`: cli/src/contracts/request.rs#L31
warning: unused import: `Write` --> cli/src/contracts/request.rs:31:36 | 31 | use std::fmt::{Display, Formatter, Write}; | ^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L358
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:358:9 | 358 | / env.memory 359 | | .as_ref() 360 | | .unwrap() 361 | | .view(&store) 362 | | .write(bytes as u64, s.as_bytes()); | |______________________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 358 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L343
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:343:9 | 343 | / env.memory 344 | | .as_ref() 345 | | .unwrap() 346 | | .view(&store) 347 | | .read(psbt, &mut buf[..]); | |_____________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 343 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L326
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:326:9 | 326 | / env.memory 327 | | .as_ref() 328 | | .unwrap() 329 | | .view(&store) 330 | | .write(bytes as u64, s.as_bytes()); | |______________________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 326 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L311
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:311:13 | 311 | / env.memory 312 | | .as_ref() 313 | | .unwrap() 314 | | .view(&store) 315 | | .read(hash, &mut buf[..]); | |_________________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 311 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L298
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:298:9 | 298 | w.write_all(&v[..]); | ^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 298 | let _ = w.write_all(&v[..]); | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L297
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:297:9 | 297 | mem.read(a as u64, &mut v[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 297 | let _ = mem.read(a as u64, &mut v[..]); | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L276
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:276:21 | 276 | / env.memory 277 | | .as_ref() 278 | | .unwrap() 279 | | .view(&store) 280 | | .write(bytes as u64, comp_s.as_bytes()); | |_______________________________________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 276 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L208
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:208:17 | 208 | / env.memory 209 | | .as_ref() 210 | | .unwrap() 211 | | .view(&store) 212 | | .read(path as u64, &mut v[..path_len as usize]); | |___________________________________________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 208 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L198
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:198:17 | 198 | / env.memory 199 | | .as_ref() 200 | | .unwrap() 201 | | .view(&store) 202 | | .read(json as u64, &mut v[..json_len as usize]); | |___________________________________________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 198 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L171
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:171:13 | 171 | / env.memory 172 | | .as_ref() 173 | | .unwrap() 174 | | .view(&store) 175 | | .read(key, &mut buf[..]); | |________________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 171 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L110
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:110:9 | 110 | / env.memory 111 | | .as_ref() 112 | | .unwrap() 113 | | .view(&store) 114 | | .write_u8(ok as u64, is_ok); | |_______________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 110 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L101
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:101:13 | 101 | / env.memory 102 | | .as_ref() 103 | | .unwrap() 104 | | .view(&store) 105 | | .write(out as u64, b); | |_____________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 101 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/mod.rs#L92
warning: unused `std::result::Result` that must be used --> plugins/src/host/mod.rs:92:17 | 92 | / env.memory 93 | | .as_ref() 94 | | .unwrap() 95 | | .view(&store) 96 | | .read(key as u64, &mut buf[..]); | |___________________________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 92 | let _ = env.memory | +++++++
unused `std::result::Result` that must be used: plugins/src/host/plugin_handle/wasm.rs#L223
warning: unused `std::result::Result` that must be used --> plugins/src/host/plugin_handle/wasm.rs:223:9 | 223 | mem.read(p, &mut v[..]); | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 223 | let _ = mem.read(p, &mut v[..]); | +++++++
unused `std::result::Result` that must be used: plugins/src/host/plugin_handle/wasm.rs#L191
warning: unused `std::result::Result` that must be used --> plugins/src/host/plugin_handle/wasm.rs:191:9 | 191 | / env.memory 192 | | .as_ref() 193 | | .ok_or(CompilationError::ModuleFailedToGetMemory( 194 | | "Memory Missing".into(), 195 | | ))? 196 | | .view(&self.store) 197 | | .write(offset as u64, &s.as_bytes()[..]); | |____________________________________________________^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 191 | let _ = env.memory | +++++++
you should consider adding a `Default` implementation for `API<Input, Output>`: plugins/src/lib.rs#L41
warning: you should consider adding a `Default` implementation for `API<Input, Output>` --> plugins/src/lib.rs:41:5 | 41 | / pub fn new() -> Self { 42 | | API { 43 | | arguments: schemars::schema_for!(Input), 44 | | returns: schemars::schema_for!(Output), 45 | | _pd: Default::default(), 46 | | } 47 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 35 + impl<Input, Output> Default for API<Input, Output> 36 + where 37 + Input: JsonSchema, 38 + Output: JsonSchema, 39 + { 40 + fn default() -> Self { 41 + Self::new() 42 + } 43 + } |
this `to_owned` call clones the Cow<'_, str> itself and does not cause the Cow<'_, str> contents to become owned: plugins/src/host/mod.rs#L214
warning: this `to_owned` call clones the Cow<'_, str> itself and does not cause the Cow<'_, str> contents to become owned --> plugins/src/host/mod.rs:214:22 | 214 | &String::from_utf8_lossy(&v[..path_len as usize]).to_owned(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_to_owned help: depending on intent, either make the Cow an Owned variant | 214 | &String::from_utf8_lossy(&v[..path_len as usize]).into_owned(), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ help: or clone the Cow itself | 214 | &String::from_utf8_lossy(&v[..path_len as usize]).clone(), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this `to_owned` call clones the Cow<'_, str> itself and does not cause the Cow<'_, str> contents to become owned: plugins/src/host/mod.rs#L204
warning: this `to_owned` call clones the Cow<'_, str> itself and does not cause the Cow<'_, str> contents to become owned --> plugins/src/host/mod.rs:204:22 | 204 | &String::from_utf8_lossy(&v[..json_len as usize]).to_owned(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_to_owned = note: `#[warn(clippy::suspicious_to_owned)]` on by default help: depending on intent, either make the Cow an Owned variant | 204 | &String::from_utf8_lossy(&v[..json_len as usize]).into_owned(), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ help: or clone the Cow itself | 204 | &String::from_utf8_lossy(&v[..json_len as usize]).clone(), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this function has too many arguments (8/7): plugins/src/host/plugin_handle/wasm.rs#L227
warning: this function has too many arguments (8/7) --> plugins/src/host/plugin_handle/wasm.rs:227:5 | 227 | / fn setup_plugin_inner<I: Into<PathBuf> + Clone>( 228 | | mut store: Store, 229 | | path: I, 230 | | this: [u8; 32], ... | 235 | | key: WASMCacheID, 236 | | ) -> Result<Self, Box<dyn Error>> { | |_____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
redundant slicing of the whole range: plugins/src/host/plugin_handle/wasm.rs#L197
warning: redundant slicing of the whole range --> plugins/src/host/plugin_handle/wasm.rs:197:35 | 197 | .write(offset as u64, &s.as_bytes()[..]); | ^^^^^^^^^^^^^^^^^ help: use the original value instead: `s.as_bytes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing = note: `#[warn(clippy::redundant_slicing)]` on by default
question mark operator is useless here: plugins/src/host/plugin_handle/wasm.rs#L88
warning: question mark operator is useless here --> plugins/src/host/plugin_handle/wasm.rs:88:9 | 88 | / Ok(Self::setup_plugin_inner( 89 | | Store::default(), 90 | | env.path.clone(), 91 | | env.this, ... | 96 | | self.key, 97 | | )?) | |___________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default help: try removing question mark and `Ok()` | 88 ~ Self::setup_plugin_inner( 89 + Store::default(), 90 + env.path.clone(), 91 + env.this, 92 + Some(env.module_map.clone()), 93 + self.net, 94 + &env.emulator, 95 + self.module.clone(), 96 + self.key, 97 + ) |
unsafe function's docs miss `# Safety` section: plugins/src/client/plugin.rs#L115
warning: unsafe function's docs miss `# Safety` section --> plugins/src/client/plugin.rs:115:5 | 115 | unsafe fn register(name: &'static str, logo: Option<&'static [u8]>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
unsafe function's docs miss `# Safety` section: plugins/src/client/plugin.rs#L63
warning: unsafe function's docs miss `# Safety` section --> plugins/src/client/plugin.rs:63:5 | 63 | / unsafe fn create_result( 64 | | p: *mut c_char, 65 | | c: *mut c_char, 66 | | ) -> Result<Self::Output, CompilationError> { | |_______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
unsafe function's docs miss `# Safety` section: plugins/src/client/plugin.rs#L57
warning: unsafe function's docs miss `# Safety` section --> plugins/src/client/plugin.rs:57:5 | 57 | unsafe fn create(p: *mut c_char, c: *mut c_char) -> *mut c_char { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
method `get_memory` is never used: plugins/src/host/plugin_handle/wasm.rs#L201
warning: method `get_memory` is never used --> plugins/src/host/plugin_handle/wasm.rs:201:8 | 100 | impl<Output> WasmPluginHandle<Output> { | ------------------------------------- method in this implementation ... 201 | fn get_memory(&self) -> Result<&Memory, CompilationError> { | ^^^^^^^^^^
field `instance` is never read: plugins/src/host/plugin_handle/wasm.rs#L64
warning: field `instance` is never read --> plugins/src/host/plugin_handle/wasm.rs:64:5 | 60 | pub struct WasmPluginHandle<Output> { | ---------------- field in this struct ... 64 | instance: Instance, | ^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
very complex type used. Consider factoring parts into `type` definitions: sapio-contrib/src/contracts/tic_tac_toe.rs#L72
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio-contrib/src/contracts/tic_tac_toe.rs:72:12 | 72 | cache: Arc<Mutex<BTreeMap<(&'static str, Board, Tile), Vec<Template>>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
useless conversion to the same type: `sapio_bitcoin::Amount`: sapio-contrib/src/contracts/op_return_chain.rs#L63
warning: useless conversion to the same type: `sapio_bitcoin::Amount` --> sapio-contrib/src/contracts/op_return_chain.rs:63:23 | 63 | tmpl.add_fees(pay_fees.into())?.into() | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `pay_fees` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
this `as_str` is redundant and can be removed as the method immediately following exists on `String` too: sapio-contrib/src/contracts/op_return_chain.rs#L51
warning: this `as_str` is redundant and can be removed as the method immediately following exists on `String` too --> sapio-contrib/src/contracts/op_return_chain.rs:51:48 | 51 | &Compiled::from_op_return(data.as_str().as_bytes())?, | ^^^^^^^^^^^^^^^^^ help: try: `as_bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_as_str = note: `#[warn(clippy::redundant_as_str)]` on by default
useless conversion to the same type: `sapio::template::builder::BuilderState<sapio::template::builder::NotAddingFees>`: sapio-contrib/src/contracts/hanukkah.rs#L157
warning: useless conversion to the same type: `sapio::template::builder::BuilderState<sapio::template::builder::NotAddingFees>` --> sapio-contrib/src/contracts/hanukkah.rs:157:15 | 157 | txn = txn.set_lock_time(candle_time)?.into(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `txn.set_lock_time(candle_time)?` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: sapio-contrib/src/contracts/hanukkah.rs#L111
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> sapio-contrib/src/contracts/hanukkah.rs:111:1 | 111 | impl Into<String> for Recipients { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` on by default help: replace the `Into` implementation with `From<contracts::hanukkah::Recipients>` | 111 ~ impl From<Recipients> for String { 112 ~ fn from(val: Recipients) -> Self { 113 ~ val.0 |
use of `default` to create a unit struct: sapio-contrib/src/contracts/federated_sidechain.rs#L77
warning: use of `default` to create a unit struct --> sapio-contrib/src/contracts/federated_sidechain.rs:77:37 | 77 | _pd: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
very complex type used. Consider factoring parts into `type` definitions: sapio-contrib/src/contracts/dynamic.rs#L59
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio-contrib/src/contracts/dynamic.rs:59:16 | 59 | let v: Vec<fn() -> Option<actions::ThenFuncAsFinishOrFunc<'static, D<'static>, ()>>> = | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
the following explicit lifetimes could be elided: 'a: sapio-contrib/src/contracts/dynamic.rs#L48
warning: the following explicit lifetimes could be elided: 'a --> sapio-contrib/src/contracts/dynamic.rs:48:22 | 48 | fn ensure_amount<'a>(&'a self, _ctx: Context) -> Result<Amount, CompilationError> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 48 - fn ensure_amount<'a>(&'a self, _ctx: Context) -> Result<Amount, CompilationError> { 48 + fn ensure_amount(&self, _ctx: Context) -> Result<Amount, CompilationError> { |
the following explicit lifetimes could be elided: 'a: sapio-contrib/src/contracts/dynamic.rs#L45
warning: the following explicit lifetimes could be elided: 'a --> sapio-contrib/src/contracts/dynamic.rs:45:17 | 45 | fn metadata<'a>(&'a self, _ctx: Context) -> Result<ObjectMetadata, CompilationError> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 45 - fn metadata<'a>(&'a self, _ctx: Context) -> Result<ObjectMetadata, CompilationError> { 45 + fn metadata(&self, _ctx: Context) -> Result<ObjectMetadata, CompilationError> { |
the following explicit lifetimes could be elided: 'a: sapio-contrib/src/contracts/dynamic.rs#L42
warning: the following explicit lifetimes could be elided: 'a --> sapio-contrib/src/contracts/dynamic.rs:42:22 | 42 | fn get_inner_ref<'a>(&'a self) -> &Self { | ^^ ^^ ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 42 - fn get_inner_ref<'a>(&'a self) -> &Self { 42 + fn get_inner_ref(&self) -> &Self { |
the following explicit lifetimes could be elided: 'a: sapio-contrib/src/contracts/dynamic.rs#L39
warning: the following explicit lifetimes could be elided: 'a --> sapio-contrib/src/contracts/dynamic.rs:39:19 | 39 | fn finish_fns<'a>(&'a self) -> &'a [fn() -> Option<actions::Guard<Self>>] { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 39 - fn finish_fns<'a>(&'a self) -> &'a [fn() -> Option<actions::Guard<Self>>] { 39 + fn finish_fns(&self) -> &[fn() -> Option<actions::Guard<Self>>] { |
the following explicit lifetimes could be elided: 'a: sapio-contrib/src/contracts/dynamic.rs#L34
warning: the following explicit lifetimes could be elided: 'a --> sapio-contrib/src/contracts/dynamic.rs:34:22 | 34 | fn finish_or_fns<'a>( | ^^ 35 | &'a self, | ^^ 36 | ) -> &'a [fn() -> Option<Box<dyn actions::CallableAsFoF<Self, Self::StatefulArguments>>>] { | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 34 ~ fn finish_or_fns( 35 ~ &self, 36 ~ ) -> &[fn() -> Option<Box<dyn actions::CallableAsFoF<Self, Self::StatefulArguments>>>] { |
very complex type used. Consider factoring parts into `type` definitions: sapio-contrib/src/contracts/dynamic.rs#L20
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio-contrib/src/contracts/dynamic.rs:20:8 | 20 | v: Vec<fn() -> Option<actions::ThenFuncAsFinishOrFunc<'a, D<'a>, ()>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
casting to the same type is unnecessary (`u64` -> `u64`): sapio-contrib/src/contracts/derivatives/risk_reversal.rs#L132
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> sapio-contrib/src/contracts/derivatives/risk_reversal.rs:132:33 | 132 | .derive_num(strike as u64)? | ^^^^^^^^^^^^^ help: try: `strike` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u64` -> `u64`): sapio-contrib/src/contracts/derivatives/put.rs#L44
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> sapio-contrib/src/contracts/derivatives/put.rs:44:33 | 44 | .derive_num(price as u64)? | ^^^^^^^^^^^^ help: try: `price` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u64` -> `u64`): sapio-contrib/src/contracts/derivatives/call.rs#L48
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> sapio-contrib/src/contracts/derivatives/call.rs:48:33 | 48 | .derive_num(price as u64)? | ^^^^^^^^^^^^ help: try: `price` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
this `impl` can be derived: sapio-contrib/src/contracts/coin_pool.rs#L134
warning: this `impl` can be derived --> sapio-contrib/src/contracts/coin_pool.rs:134:1 | 134 | / impl Default for UpdateTypes { 135 | | fn default() -> Self { 136 | | UpdateTypes::NoUpdate 137 | | } 138 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = help: remove the manual implementation... help: ...and instead derive it... | 114 + #[derive(Default)] 115 | pub enum UpdateTypes { | help: ...and mark the default variant | 132 ~ #[default] 133 ~ NoUpdate, |
useless conversion to the same type: `sapio_bitcoin::util::amount::CoinAmount`: sapio-contrib/src/contracts/channel.rs#L273
warning: useless conversion to the same type: `sapio_bitcoin::util::amount::CoinAmount` --> sapio-contrib/src/contracts/channel.rs:273:29 | 273 | amount: self.amount.try_into().unwrap(), | ^^^^^^^^^^^^^^^^^^^^^^ | = help: consider removing `.try_into()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
very complex type used. Consider factoring parts into `type` definitions: sapio-contrib/src/contracts/channel.rs#L158
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio-contrib/src/contracts/channel.rs:158:30 | 158 | static ref DB_TYPES: Mutex<BTreeMap<String, fn(&str) -> Arc<Mutex<dyn DB>>>> = | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
this `impl` can be derived: sapio-contrib/src/contracts/channel.rs#L111
warning: this `impl` can be derived --> sapio-contrib/src/contracts/channel.rs:111:1 | 111 | / impl Default for Args { 112 | | fn default() -> Self { 113 | | Args::None 114 | | } 115 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it... | 105 + #[derive(Default)] 106 | pub enum Args { | help: ...and mark the default variant | 109 ~ #[default] 110 ~ None, |
function `candles_left` is never used: sapio-contrib/src/contracts/hanukkah.rs#L34
warning: function `candles_left` is never used --> sapio-contrib/src/contracts/hanukkah.rs:34:4 | 34 | fn candles_left(s: u8) -> u8 { | ^^^^^^^^^^^^
variants `LinearPositive`, `GeometricPositive`, and `Sigmoid` are never constructed: sapio-contrib/src/contracts/derivatives/dlc.rs#L142
warning: variants `LinearPositive`, `GeometricPositive`, and `Sigmoid` are never constructed --> sapio-contrib/src/contracts/derivatives/dlc.rs:142:5 | 139 | enum SplitFunctions { | -------------- variants in this enum ... 142 | LinearPositive(Intercept), | ^^^^^^^^^^^^^^ 143 | /// A Geometric starting at the intercept parameter to 1.0 144 | GeometricPositive(Intercept), | ^^^^^^^^^^^^^^^^^ ... 149 | Sigmoid(Offset), | ^^^^^^^ | = note: `SplitFunctions` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
field `url` is never read: sapio-contrib/src/contracts/derivatives/dlc.rs#L30
warning: field `url` is never read --> sapio-contrib/src/contracts/derivatives/dlc.rs:30:5 | 29 | struct BasicOracle { | ----------- field in this struct 30 | url: String, | ^^^
field `0` is never read: sapio-contrib/src/contracts/derivatives/dlc.rs#L19
warning: field `0` is never read --> sapio-contrib/src/contracts/derivatives/dlc.rs:19:14 | 19 | struct Event(String); | ----- ^^^^^^ | | | field in this struct | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 19 | struct Event(()); | ~~
function `register_db` is never used: sapio-contrib/src/contracts/channel.rs#L162
warning: function `register_db` is never used --> sapio-contrib/src/contracts/channel.rs:162:12 | 162 | pub fn register_db(s: String, f: fn(&str) -> Arc<Mutex<dyn DB>>) { | ^^^^^^^^^^^
fields `revoke` and `split` are never read: sapio-contrib/src/contracts/channel.rs#L89
warning: fields `revoke` and `split` are never read --> sapio-contrib/src/contracts/channel.rs:89:5 | 87 | pub struct Update { | ------ fields in this struct 88 | /// hash to revoke 89 | revoke: bitcoin::hashes::sha256::Hash, | ^^^^^^ 90 | /// the balances of the channel 91 | split: (CoinAmount, CoinAmount), | ^^^^^ | = note: `Update` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
unused `std::result::Result` that must be used: examples/dcf_mining_pool/src/main.rs#L121
warning: unused `std::result::Result` that must be used --> examples/dcf_mining_pool/src/main.rs:121:13 | 121 | v.await; | ^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 121 | let _ = v.await; | +++++++
empty `loop {}` wastes CPU cycles: examples/dcf_mining_pool/src/main.rs#L210
warning: empty `loop {}` wastes CPU cycles --> examples/dcf_mining_pool/src/main.rs:210:5 | 210 | loop {} | ^^^^^^^ | = help: you should either use `panic!()` or add `std::thread::sleep(..);` to the loop body = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop = note: `#[warn(clippy::empty_loop)]` on by default
method `compute_for_block` is never used: examples/dcf_mining_pool/src/main.rs#L69
warning: method `compute_for_block` is never used --> examples/dcf_mining_pool/src/main.rs:69:14 | 68 | impl Coordinator { | ---------------- method in this implementation 69 | async fn compute_for_block( | ^^^^^^^^^^^^^^^^^
struct `Coordinator` is never constructed: examples/dcf_mining_pool/src/main.rs#L62
warning: struct `Coordinator` is never constructed --> examples/dcf_mining_pool/src/main.rs:62:8 | 62 | struct Coordinator { | ^^^^^^^^^^^
associated function `from_block` is never used: examples/dcf_mining_pool/src/main.rs#L33
warning: associated function `from_block` is never used --> examples/dcf_mining_pool/src/main.rs:33:8 | 32 | impl BlockNotes { | --------------- associated function in this implementation 33 | fn from_block(block: Block) -> BlockNotes { | ^^^^^^^^^^
field `participated` is never read: examples/dcf_mining_pool/src/main.rs#L29
warning: field `participated` is never read --> examples/dcf_mining_pool/src/main.rs:29:5 | 26 | struct BlockNotes { | ---------- field in this struct ... 29 | participated: Option<bool>, | ^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unused doc comment: examples/dcf_mining_pool/src/main.rs#L186
warning: unused doc comment --> examples/dcf_mining_pool/src/main.rs:186:13 | 186 | /// all of the payments needing to be sent | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 187 | participants, | ------------ rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment = note: `#[warn(unused_doc_comments)]` on by default
use of deprecated associated function `sapio_bitcoin::util::bip32::ExtendedPubKey::from_private`: use ExtendedPubKey::from_priv: ctv_emulators/src/bin/main.rs#L24
warning: use of deprecated associated function `sapio_bitcoin::util::bip32::ExtendedPubKey::from_private`: use ExtendedPubKey::from_priv --> ctv_emulators/src/bin/main.rs:24:35 | 24 | let pk_root = ExtendedPubKey::from_private(&Secp256k1::new(), &root); | ^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: sapio-psbt/src/lib.rs#L219
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> sapio-psbt/src/lib.rs:219:27 | 219 | fingerprints_map: &'a Vec<(Fingerprint, &'a ExtendedPrivKey)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&'a [(Fingerprint, &'a ExtendedPrivKey)]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: sapio-psbt/src/lib.rs#L188
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> sapio-psbt/src/lib.rs:188:27 | 188 | fingerprints_map: &Vec<(Fingerprint, &ExtendedPrivKey)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Fingerprint, &ExtendedPrivKey)]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default
use of deprecated associated function `sapio_bitcoin::sapio_secp256k1::Message::from_slice`: use from_digest_slice instead: sapio-psbt/src/lib.rs#L283
warning: use of deprecated associated function `sapio_bitcoin::sapio_secp256k1::Message::from_slice`: use from_digest_slice instead --> sapio-psbt/src/lib.rs:283:44 | 283 | let msg = bitcoin::secp256k1::Message::from_slice(&sighash[..]).expect("Size must be correct."); | ^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
unnecessary parentheses around assigned value: sapio-contrib/src/contracts/op_return_chain.rs#L46
warning: unnecessary parentheses around assigned value --> sapio-contrib/src/contracts/op_return_chain.rs:46:28 | 46 | let mut pay_fees = (Amount::ZERO); | ^ ^ | = note: `#[warn(unused_parens)]` on by default help: remove these parentheses | 46 - let mut pay_fees = (Amount::ZERO); 46 + let mut pay_fees = Amount::ZERO; |
casting to the same type is unnecessary (`usize` -> `usize`): ctv_emulators/src/msgs.rs#L46
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> ctv_emulators/src/msgs.rs:46:42 | 46 | || de::Error::invalid_length(self.0 as usize, &"Expected at least 4 bytes."); | ^^^^^^^^^^^^^^^ help: try: `self.0` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
name `PSBT` contains a capitalized acronym: ctv_emulators/src/msgs.rs#L20
warning: name `PSBT` contains a capitalized acronym --> ctv_emulators/src/msgs.rs:20:12 | 20 | pub struct PSBT(pub PartiallySignedTransaction); | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Psbt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms = note: `#[warn(clippy::upper_case_acronyms)]` on by default
constant `MAX_MSG` is never used: ctv_emulators/src/lib.rs#L27
warning: constant `MAX_MSG` is never used --> ctv_emulators/src/lib.rs:27:7 | 27 | const MAX_MSG: usize = 1_000_000; | ^^^^^^^ | = note: `#[warn(dead_code)]` on by default
use of deprecated associated function `sapio_bitcoin::sapio_secp256k1::Message::from_slice`: use from_digest_slice instead: ctv_emulators/src/servers/hd.rs#L98
warning: use of deprecated associated function `sapio_bitcoin::sapio_secp256k1::Message::from_slice`: use from_digest_slice instead --> ctv_emulators/src/servers/hd.rs:98:52 | 98 | let msg = bitcoin::secp256k1::Message::from_slice(&sighash[..]) | ^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
useless conversion to the same type: `sapio_bitcoin::Amount`: sapio/src/ordinals/mod.rs#L283
warning: useless conversion to the same type: `sapio_bitcoin::Amount` --> sapio/src/ordinals/mod.rs:283:57 | 283 | base_instructions.push(PlanStep::Payout(v.into())); | ^^^^^^^^ help: consider removing `.into()`: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `sapio_bitcoin::Amount`: sapio/src/ordinals/mod.rs#L255
warning: useless conversion to the same type: `sapio_bitcoin::Amount` --> sapio/src/ordinals/mod.rs:255:50 | 255 | base_instructions.push(PlanStep::Fee(spec.fees.into())); | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `spec.fees` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
length comparison to zero: sapio/src/ordinals/mod.rs#L244
warning: length comparison to zero --> sapio/src/ordinals/mod.rs:244:16 | 244 | if payouts.len() > 0 { | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payouts.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default
unneeded `return` statement: sapio/src/ordinals/mod.rs#L136
warning: unneeded `return` statement --> sapio/src/ordinals/mod.rs:136:13 | 136 | return Err(CompilationError::OutOfFunds); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 136 - return Err(CompilationError::OutOfFunds); 136 + Err(CompilationError::OutOfFunds) |
useless conversion to the same type: `sapio_bitcoin::Amount`: sapio/src/ordinals/mod.rs#L98
warning: useless conversion to the same type: `sapio_bitcoin::Amount` --> sapio/src/ordinals/mod.rs:98:44 | 98 | tmpl = tmpl.add_output(amt.into(), contract, metadata)?; | ^^^^^^^^^^ help: consider removing `.into()`: `amt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `sapio_bitcoin::Amount`: sapio/src/ordinals/mod.rs#L91
warning: useless conversion to the same type: `sapio_bitcoin::Amount` --> sapio/src/ordinals/mod.rs:91:35 | 91 | .get_mut(&amt.into()) | ^^^^^^^^^^ help: consider removing `.into()`: `amt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `sapio_bitcoin::Amount`: sapio/src/ordinals/mod.rs#L87
warning: useless conversion to the same type: `sapio_bitcoin::Amount` --> sapio/src/ordinals/mod.rs:87:44 | 87 | tmpl = tmpl.add_output(amt.into(), change, change_meta.clone())?; | ^^^^^^^^^^ help: consider removing `.into()`: `amt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `sapio_bitcoin::Amount`: sapio/src/ordinals/mod.rs#L84
warning: useless conversion to the same type: `sapio_bitcoin::Amount` --> sapio/src/ordinals/mod.rs:84:42 | 84 | return tmpl.add_fees(f.into()); | ^^^^^^^^ help: consider removing `.into()`: `f` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
very complex type used. Consider factoring parts into `type` definitions: sapio/src/ordinals/mod.rs#L76
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio/src/ordinals/mod.rs:76:17 | 76 | mut bs: BTreeMap<Amount, Vec<(&dyn Compilable, Option<OutputMeta>)>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
returning the result of a `let` binding from a block: sapio/src/util/extended_address.rs#L100
warning: returning the result of a `let` binding from a block --> sapio/src/util/extended_address.rs:100:17 | 99 | let r = d.script_pubkey(); | -------------------------- unnecessary `let` binding 100 | r | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 99 ~ 100 ~ d.script_pubkey() |
you should consider adding a `Default` implementation for `AmountRange`: sapio/src/util/amountrange.rs#L78
warning: you should consider adding a `Default` implementation for `AmountRange` --> sapio/src/util/amountrange.rs:78:5 | 78 | / pub fn new() -> AmountRange { 79 | | AmountRange { 80 | | min: None, 81 | | max: None, 82 | | } 83 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try adding this | 76 + impl Default for AmountRange { 77 + fn default() -> Self { 78 + Self::new() 79 + } 80 + } |
you should consider adding a `Default` implementation for `TemplateMetadata`: sapio/src/template/mod.rs#L49
warning: you should consider adding a `Default` implementation for `TemplateMetadata` --> sapio/src/template/mod.rs:49:5 | 49 | / pub fn new() -> Self { 50 | | TemplateMetadata { 51 | | simp: BTreeMap::new(), 52 | | color: None, ... | 55 | | } 56 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 43 + impl Default for TemplateMetadata { 44 + fn default() -> Self { 45 + Self::new() 46 + } 47 + } |
use of a fallible conversion when an infallible one could be used: sapio/src/template/builder.rs#L254
warning: use of a fallible conversion when an infallible one could be used --> sapio/src/template/builder.rs:254:27 | 254 | let default_seq = RelTime::try_from(0).unwrap().into(); | ^^^^^^^^^^^^^^^^^ help: use: `From::from` | = note: converting `u16` to `LockTime<Rel, MTP>` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
returning the result of a `let` binding from a block: sapio/src/template/builder.rs#L285
warning: returning the result of a `let` binding from a block --> sapio/src/template/builder.rs:285:9 | 279 | / let t = bitcoin::Transaction { 280 | | version: self.version, 281 | | lock_time: self.lock_time.unwrap_or(default_nlt).get(), 282 | | input, 283 | | output, 284 | | }; | |__________- unnecessary `let` binding 285 | t | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 279 ~ 280 ~ bitcoin::Transaction { 281 + version: self.version, 282 + lock_time: self.lock_time.unwrap_or(default_nlt).get(), 283 + input, 284 + output, 285 + } |
this `impl` can be derived: sapio/src/template/output.rs#L42
warning: this `impl` can be derived --> sapio/src/template/output.rs:42:1 | 42 | / impl Default for OutputMeta { 43 | | fn default() -> Self { 44 | | OutputMeta { 45 | | extra: Default::default(), ... | 48 | | } 49 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = help: remove the manual implementation... help: ...and instead derive it | 13 + #[derive(Default)] 14 | pub struct OutputMeta { |
this `impl` can be derived: sapio/src/template/input.rs#L56
warning: this `impl` can be derived --> sapio/src/template/input.rs:56:1 | 56 | / impl Default for InputMetadata { 57 | | fn default() -> Self { 58 | | InputMetadata { 59 | | extra: Default::default(), ... | 62 | | } 63 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it | 13 + #[derive(Default)] 14 | pub struct InputMetadata { |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L190
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:190:22 | 190 | fn ensure_amount<'a>(&'a self, ctx: Context) -> Result<Amount, CompilationError> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 190 - fn ensure_amount<'a>(&'a self, ctx: Context) -> Result<Amount, CompilationError> { 190 + fn ensure_amount(&self, ctx: Context) -> Result<Amount, CompilationError> { |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L187
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:187:17 | 187 | fn metadata<'a>(&'a self, ctx: Context) -> Result<ObjectMetadata, CompilationError> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 187 - fn metadata<'a>(&'a self, ctx: Context) -> Result<ObjectMetadata, CompilationError> { 187 + fn metadata(&self, ctx: Context) -> Result<ObjectMetadata, CompilationError> { |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L183
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:183:22 | 183 | fn get_inner_ref<'a>(&'a self) -> &Self::Ref { | ^^ ^^ ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 183 - fn get_inner_ref<'a>(&'a self) -> &Self::Ref { 183 + fn get_inner_ref(&self) -> &Self::Ref { |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L180
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:180:19 | 180 | fn finish_fns<'a>(&'a self) -> &'a [fn() -> Option<actions::Guard<Self::Ref>>] { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 180 - fn finish_fns<'a>(&'a self) -> &'a [fn() -> Option<actions::Guard<Self::Ref>>] { 180 + fn finish_fns(&self) -> &[fn() -> Option<actions::Guard<Self::Ref>>] { |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L174
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:174:22 | 174 | fn finish_or_fns<'a>( | ^^ 175 | &'a self, | ^^ 176 | ) -> &'a [fn() -> Option<Box<dyn actions::CallableAsFoF<Self::Ref, Self::StatefulArguments>>>] | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 174 ~ fn finish_or_fns( 175 ~ &self, 176 ~ ) -> &[fn() -> Option<Box<dyn actions::CallableAsFoF<Self::Ref, Self::StatefulArguments>>>] |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L154
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:154:22 | 154 | fn ensure_amount<'a>(&'a self, ctx: Context) -> Result<Amount, CompilationError>; | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 154 - fn ensure_amount<'a>(&'a self, ctx: Context) -> Result<Amount, CompilationError>; 154 + fn ensure_amount(&self, ctx: Context) -> Result<Amount, CompilationError>; |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L152
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:152:17 | 152 | fn metadata<'a>(&'a self, ctx: Context) -> Result<ObjectMetadata, CompilationError>; | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 152 - fn metadata<'a>(&'a self, ctx: Context) -> Result<ObjectMetadata, CompilationError>; 152 + fn metadata(&self, ctx: Context) -> Result<ObjectMetadata, CompilationError>; |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L150
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:150:22 | 150 | fn get_inner_ref<'a>(&'a self) -> &'a Self::Ref; | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 150 - fn get_inner_ref<'a>(&'a self) -> &'a Self::Ref; 150 + fn get_inner_ref(&self) -> &Self::Ref; |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L148
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:148:19 | 148 | fn finish_fns<'a>(&'a self) -> &'a [fn() -> Option<actions::Guard<Self::Ref>>]; | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 148 - fn finish_fns<'a>(&'a self) -> &'a [fn() -> Option<actions::Guard<Self::Ref>>]; 148 + fn finish_fns(&self) -> &[fn() -> Option<actions::Guard<Self::Ref>>]; |
very complex type used. Consider factoring parts into `type` definitions: sapio/src/contract/mod.rs#L148
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio/src/contract/mod.rs:148:36 | 148 | fn finish_fns<'a>(&'a self) -> &'a [fn() -> Option<actions::Guard<Self::Ref>>]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L144
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:144:22 | 144 | fn finish_or_fns<'a>( | ^^ 145 | &'a self, | ^^ 146 | ) -> &'a [fn() -> Option<Box<dyn actions::CallableAsFoF<Self::Ref, Self::StatefulArguments>>>]; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 144 ~ fn finish_or_fns( 145 ~ &self, 146 ~ ) -> &[fn() -> Option<Box<dyn actions::CallableAsFoF<Self::Ref, Self::StatefulArguments>>>]; |
very complex type used. Consider factoring parts into `type` definitions: sapio/src/contract/mod.rs#L146
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio/src/contract/mod.rs:146:10 | 146 | ) -> &'a [fn() -> Option<Box<dyn actions::CallableAsFoF<Self::Ref, Self::StatefulArguments>>>]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: sapio/src/contract/mod.rs#L137
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio/src/contract/mod.rs:137:10 | 137 | ) -> &'a [fn() -> Option< | __________^ 138 | | actions::ThenFuncAsFinishOrFunc<'a, Self::Ref, Self::StatefulArguments>, 139 | | >] | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L109
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:109:22 | 109 | fn ensure_amount<'a>(&'a self, ctx: Context) -> Result<Amount, CompilationError> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 109 - fn ensure_amount<'a>(&'a self, ctx: Context) -> Result<Amount, CompilationError> { 109 + fn ensure_amount(&self, ctx: Context) -> Result<Amount, CompilationError> { |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L105
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:105:17 | 105 | fn metadata<'a>(&'a self, ctx: Context) -> Result<ObjectMetadata, CompilationError> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 105 - fn metadata<'a>(&'a self, ctx: Context) -> Result<ObjectMetadata, CompilationError> { 105 + fn metadata(&self, ctx: Context) -> Result<ObjectMetadata, CompilationError> { |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L98
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:98:19 | 98 | fn finish_fns<'a>(&'a self) -> &'a [fn() -> Option<actions::Guard<S>>] { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 98 - fn finish_fns<'a>(&'a self) -> &'a [fn() -> Option<actions::Guard<S>>] { 98 + fn finish_fns(&self) -> &[fn() -> Option<actions::Guard<S>>] { |
the following explicit lifetimes could be elided: 'a: sapio/src/contract/mod.rs#L93
warning: the following explicit lifetimes could be elided: 'a --> sapio/src/contract/mod.rs:93:22 | 93 | fn finish_or_fns<'a>( | ^^ 94 | &'a self, | ^^ 95 | ) -> &'a [fn() -> Option<Box<dyn actions::CallableAsFoF<S, Self::StatefulArguments>>>] { | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 93 ~ fn finish_or_fns( 94 ~ &self, 95 ~ ) -> &[fn() -> Option<Box<dyn actions::CallableAsFoF<S, Self::StatefulArguments>>>] { |
very complex type used. Consider factoring parts into `type` definitions: sapio/src/contract/mod.rs#L73
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio/src/contract/mod.rs:73:26 | 73 | pub ensure_amount_f: Box<dyn (Fn(&S, Context) -> Result<Amount, CompilationError>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: sapio/src/contract/mod.rs#L71
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio/src/contract/mod.rs:71:21 | 71 | pub metadata_f: Box<dyn (Fn(&S, Context) -> Result<ObjectMetadata, CompilationError>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: sapio/src/contract/mod.rs#L67
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio/src/contract/mod.rs:67:20 | 67 | pub finish_or: Vec<fn() -> Option<Box<dyn actions::CallableAsFoF<S, T>>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: sapio/src/contract/mod.rs#L65
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio/src/contract/mod.rs:65:15 | 65 | pub then: Vec<fn() -> Option<actions::ThenFuncAsFinishOrFunc<'a, S, T>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
this lifetime isn't used in the function definition: sapio/src/contract/context.rs#L99
warning: this lifetime isn't used in the function definition --> sapio/src/contract/context.rs:99:23 | 99 | pub fn derive_str<'a>(&mut self, path: Arc<String>) -> Result<Self, CompilationError> { | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
unsafe function's docs miss `# Safety` section: sapio/src/contract/context.rs#L86
warning: unsafe function's docs miss `# Safety` section --> sapio/src/contract/context.rs:86:5 | 86 | pub unsafe fn get_effects_internal(&self) -> &Arc<MapEffectDB> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
returning the result of a `let` binding from a block: sapio/src/contract/compiler/mod.rs#L406
warning: returning the result of a `let` binding from a block --> sapio/src/contract/compiler/mod.rs:406:13 | 402 | / let r = Ok(txtmpl_clauses 403 | | .into_iter() 404 | | .map(|policy| policy.compile().map_err(Into::<CompilationError>::into)) 405 | | .collect::<Result<Vec<_>, _>>()?); | |__________________________________________________- unnecessary `let` binding 406 | r | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 402 ~ 403 ~ Ok(txtmpl_clauses 404 + .into_iter() 405 + .map(|policy| policy.compile().map_err(Into::<CompilationError>::into)) 406 + .collect::<Result<Vec<_>, _>>()?) |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: sapio/src/contract/compiler/mod.rs#L324
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> sapio/src/contract/compiler/mod.rs:324:24 | 324 | .chain(clause_accumulator.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `clause_accumulator` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/88189a71e4e4376eea82ac61db6a539612eb200a/library/core/src/iter/traits/iterator.rs:524:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
returning the result of a `let` binding from a block: sapio/src/contract/compiler/mod.rs#L272
warning: returning the result of a `let` binding from a block --> sapio/src/contract/compiler/mod.rs:272:21 | 267 | / let r = ( 268 | | None, 269 | | combine_txtmpls(nullability, txtmpl_clauses, guards)?, 270 | | guard_metadata, 271 | | ); | |______________________- unnecessary `let` binding 272 | r | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 267 ~ 268 ~ ( 269 + None, 270 + combine_txtmpls(nullability, txtmpl_clauses, guards)?, 271 + guard_metadata, 272 + ) |
this lifetime isn't used in the impl: sapio/src/contract/compiler/mod.rs#L47
warning: this lifetime isn't used in the impl --> sapio/src/contract/compiler/mod.rs:47:10 | 47 | impl<'a, C> ImplSeal for C where C: super::AnyContract {} | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
very complex type used. Consider factoring parts into `type` definitions: sapio/src/contract/actions/finish.rs#L30
warning: very complex type used. Consider factoring parts into `type` definitions --> sapio/src/contract/actions/finish.rs:30:19 | 30 | pub simp_gen: Option< | ___________________^ 31 | | fn( 32 | | &ContractSelf, 33 | | Context, ... | 36 | | -> Result<Vec<Box<dyn SIMPAttachableAt<ContinuationPointLT>>>, CompilationError>, 37 | | >, | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
use of `default` to create a unit struct: sapio/src/contract/actions/then.rs#L61
warning: use of `default` to create a unit struct --> sapio/src/contract/actions/then.rs:61:27 | 61 | f: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
usage of `Iterator::fold` on a type that implements `Try`: sapio/src/contract/abi/object/mod.rs#L85
warning: usage of `Iterator::fold` on a type that implements `Try` --> sapio/src/contract/abi/object/mod.rs:85:39 | 85 | v.into_iter().fold( | _______________________________________^ 86 | | Ok(Default::default()), 87 | | |ra: Result<BTreeMap<_, Vec<Value>>, CompilationError>, b| { 88 | | let mut a = ra?; ... | 93 | | }, 94 | | )?, | |_________________________^ help: use `try_fold` instead: `try_fold(Default::default(), |ra: Result<BTreeMap<_, Vec<Value>>, CompilationError>, b| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default
field assignment outside of initializer for an instance created with Default::default(): sapio/src/contract/abi/object/bind.rs#L51
warning: field assignment outside of initializer for an instance created with Default::default() --> sapio/src/contract/abi/object/bind.rs:51:9 | 51 | mock_out.vout = 0; | ^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `sapio_bitcoin::OutPoint { vout: 0, ..Default::default() }` and removing relevant reassignments --> sapio/src/contract/abi/object/bind.rs:50:9 | 50 | let mut mock_out = OutPoint::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default = note: `#[warn(clippy::field_reassign_with_default)]` on by default
variable does not need to be mutable: sapio/src/ordinals/mod.rs#L157
warning: variable does not need to be mutable --> sapio/src/ordinals/mod.rs:157:21 | 157 | let mut it = info.iter_mut().peekable(); | ----^^ | | | help: remove this `mut`
unused variable: `upper`: sapio/src/ordinals/mod.rs#L202
warning: unused variable: `upper` --> sapio/src/ordinals/mod.rs:202:30 | 202 | let ((lower, upper), _) = &mut info[info_idx]; | ^^^^^ help: if this is intentional, prefix it with an underscore: `_upper`
unused variable: `it`: sapio/src/ordinals/mod.rs#L157
warning: unused variable: `it` --> sapio/src/ordinals/mod.rs:157:25 | 157 | let mut it = info.iter_mut().peekable(); | ^^ help: if this is intentional, prefix it with an underscore: `_it` | = note: `#[warn(unused_variables)]` on by default
variable does not need to be mutable: sapio/src/template/builder.rs#L233
warning: variable does not need to be mutable --> sapio/src/template/builder.rs:233:13 | 233 | let mut s = BuilderState { | ----^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default
unused import: `SIMP`: sapio/src/template/output.rs#L9
warning: unused import: `SIMP` --> sapio/src/template/output.rs:9:53 | 9 | use sapio_base::simp::{SIMPError, TemplateOutputLT, SIMP}; | ^^^^
unused import: `SIMP`: sapio/src/contract/abi/continuation.rs#L10
warning: unused import: `SIMP` --> sapio/src/contract/abi/continuation.rs:10:53 | 10 | use sapio_base::simp::{SIMPAttachableAt, SIMPError, SIMP}; | ^^^^
use of deprecated method `sapio_bitcoin::Transaction::get_weight`: Please use `transaction::weight` instead.: sapio/src/contract/compiler/mod.rs#L342
warning: use of deprecated method `sapio_bitcoin::Transaction::get_weight`: Please use `transaction::weight` instead. --> sapio/src/contract/compiler/mod.rs:342:32 | 342 | let tx_size = a.tx.get_weight() + estimated_max_size; | ^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
unused imports: `Deserialize`, `Serialize`: sapio/src/ordinals/mod.rs#L21
warning: unused imports: `Deserialize`, `Serialize` --> sapio/src/ordinals/mod.rs:21:20 | 21 | use serde_derive::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^
unused imports: `AmountF64`, `AmountU64`, `Builder`, `TxTmplIt`: sapio/src/ordinals/mod.rs#L10
warning: unused imports: `AmountF64`, `AmountU64`, `Builder`, `TxTmplIt` --> sapio/src/ordinals/mod.rs:10:46 | 10 | contract::{Compilable, CompilationError, TxTmplIt}, | ^^^^^^^^ ... 13 | Builder, OutputMeta, | ^^^^^^^ 14 | }, 15 | util::amountrange::{AmountF64, AmountU64}, | ^^^^^^^^^ ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
private item shadows public glob re-export: sapio-base/src/effects/mod.rs#L9
warning: private item shadows public glob re-export --> sapio-base/src/effects/mod.rs:9:5 | 9 | use crate::reverse_path::ReversePath; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the name `ReversePath` in the type namespace is supposed to be publicly re-exported here --> sapio-base/src/effects/mod.rs:19:9 | 19 | pub use reverse_path::*; | ^^^^^^^^^^^^^^^ note: but the private item here shadows it --> sapio-base/src/effects/mod.rs:9:5 | 9 | use crate::reverse_path::ReversePath; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(hidden_glob_reexports)]` on by default
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly - ASan + Bench (nightly)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Nightly - ASan + Bench (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly - ASan + Bench (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly - ASan + Bench (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly - ASan + Bench (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (1.75.0)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests (1.75.0)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (1.75.0)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (1.75.0)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (1.75.0)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly - Docs / WebAssembly Build + Tests (nightly)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Nightly - Docs / WebAssembly Build + Tests (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly - Docs / WebAssembly Build + Tests (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly - Docs / WebAssembly Build + Tests (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly - Docs / WebAssembly Build + Tests (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/