Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Promise-based fs methods #435

Merged
merged 2 commits into from Mar 20, 2022
Merged

Convert to Promise-based fs methods #435

merged 2 commits into from Mar 20, 2022

Conversation

groenroos
Copy link
Member

@groenroos groenroos commented Mar 20, 2022

Convert from Sync methods to Promise-based methods to improve server performance.

Did not do it for test suites, as blocking is less important there. There is also a check in Uploads that needs refactoring, but no clear way how to do that.

Closes #432.

@groenroos groenroos added this to the M2 - Release 2.0 milestone Mar 20, 2022
@groenroos groenroos self-assigned this Mar 20, 2022
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #435 (65c0f96) into master (798f4e3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   98.02%   98.07%   +0.04%     
==========================================
  Files          37       37              
  Lines        4607     4668      +61     
==========================================
+ Hits         4516     4578      +62     
+ Misses         91       90       -1     
Impacted Files Coverage Δ
core/loadConfig.js 100.00% <100.00%> (ø)
core/loadController.js 100.00% <100.00%> (ø)
core/loadHooks.js 98.85% <100.00%> (ø)
core/loadModel.js 100.00% <100.00%> (ø)
core/loadPermissions.js 100.00% <100.00%> (ø)
drivers/render/Html.js 100.00% <100.00%> (ø)
lib/Utils.js 100.00% <100.00%> (ø)
lib/Uploads.js 98.78% <0.00%> (+0.21%) ⬆️
lib/Templating.js 99.07% <0.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798f4e3...65c0f96. Read the comment docs.

@groenroos groenroos merged commit 7a3cc98 into master Mar 20, 2022
@groenroos groenroos deleted the fix/promise-fs branch March 20, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use Promise-based fs methods
1 participant