Fix of bug #756 #757
Merged
Fix of bug #756 #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull latest abap2xlsx changes
Remove doma ZEXCEL_BOOLE01 (abap2xlsx#738)
AUnit warning zcl excel reader huge file "# au > "#au abap2xlsx#739 (abap2xlsx#742)
Synchronize latest changes from master sapmentors/abap2xlsx
Fix of bug abap2xlsx#756 Vietnamese/Emoji should now be rendered in systems before ABAP 7.52
|
@sandraros the system is isolated so I copied the whole class from the PR, verified it has the new "Excerpt from Note" block and ran the same demo: below is the output as shown by LibreOffice on my Linux desktop. |
|
Great. So, if you approve the code, I guess the PR can be merged now. |
AndreaBorgia-Abo
approved these changes
May 30, 2021
AndreaBorgia-Abo
approved these changes
Jun 26, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution to complement PR #743
Vietnamese/Emoji should now be rendered in systems before ABAP 7.52