Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erratic naming convention of variables #778

Merged

Conversation

sandraros
Copy link
Collaborator

@sandraros sandraros commented Jul 11, 2021

That's a proposal to be discussed.
Note that I didn't add a link in the Contributing Guidelines.

Copy link
Member

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given an impossible task, this is the best we can do to maintain some semblance of sanity.
Thank you for the summary, I think we may add it to the project and I'll link to it in contributing.md once done.

@AndreaBorgia-Abo
Copy link
Member

AndreaBorgia-Abo commented Jul 26, 2021

At the moment we have all misc documentation under docs/ and there is no docs/contributing/ subdir.
I suggest that we move this file one level up and forego the additional subdir.
(I have added the link to CONTRIBUTING.md in #769 assuming the suggestion is acceptable)

@larshp
Copy link
Member

larshp commented Jul 27, 2021

approved above, merging

@larshp larshp merged commit 6edf73b into abap2xlsx:master Jul 27, 2021
@AndreaBorgia-Abo
Copy link
Member

Uhm, we now have a docs/contributing/ directory: do we keep it? If so, I'll fix the link in CONTRIBUTING.md

@sandraros sandraros deleted the Erratic-naming-convention-of-variables branch October 24, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants