Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #703 excel date empty/0/1.0.1900 > abap 18991231 #792

Conversation

sandraros
Copy link
Collaborator

With this fix, Excel date empty/0/1.0.1900 > abap 00000000.
It will also help a lot in #787 so that the OP can delete easily the empty lines after GET_TABLE.

@AndreaBorgia-Abo
Copy link
Member

I'll try this out hopefully tomorrow evening.

@AndreaBorgia-Abo
Copy link
Member

Tweaked ZDEMO_EXCEL24 to write an empty date, saved file, ran ZDEMO_EXCEL15 to read the file back.
With master branch: date is read back as 18991231 (nope)
With PR branch: date is read back as 00000000 (ok)
Unit tests pass, looks good to me, merging.

@AndreaBorgia-Abo AndreaBorgia-Abo merged commit 3b80566 into abap2xlsx:master Sep 14, 2021
@sandraros sandraros deleted the Fix-#703-Excel-date-empty/0/1.0.1900-->-ABAP-18991231 branch September 21, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants