Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ink.UI.Toggle: allow target as an element #46

Closed
mping opened this issue Jun 4, 2013 · 1 comment
Closed

Ink.UI.Toggle: allow target as an element #46

mping opened this issue Jun 4, 2013 · 1 comment
Assignees
@suskind

Comments

@mping
Copy link

mping commented Jun 4, 2013

Currently, the options hash of the Ink.UI.Toggle_1 constructor only allows the target as selector string. This should allow passing a DOM element as well, for easier integration with other js libs.
@ghost ghost assigned mAiNiNfEcTiOn and suskind Jun 5, 2013
@mAiNiNfEcTiOn
Copy link
Contributor

Hi @mping , I've taken into account that suggestion and done the change. Will be ready in the next minor release.

pedrocorreia pushed a commit that referenced this issue Jun 12, 2013
Added the possibility to set a DOM Element as a target on the Toggle …
1b499bf 
…(via Javascript configuration). This fixes the Github's #46 issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suskind suskind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mping @suskind @pedrocorreia @mAiNiNfEcTiOn