Skip to content

Commit

Permalink
more whatsnew style fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
sappelhoff committed Apr 15, 2020
1 parent 9523b46 commit 18e0bf4
Showing 1 changed file with 13 additions and 15 deletions.
28 changes: 13 additions & 15 deletions docs/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,13 @@ Changelog
~~~~~~~~~

- Include a boolean ``do_detrend`` in :meth:`reference.robust_reference` to indicate whether detrend should be done internally or not for the use with :mod:`find_noisy_channels`, by `Yorguin Mantilla`_ (`#9 <https://github.com/sappelhoff/pyprep/pull/9>`_)
- Robust average referencing + tests by `Victor Xiang`_
- Removing trend in the EEG data by high pass filtering and local linear regression + tests `Aamna Lawrence`_
- Finding noisy channels with comparable output to Matlab +tests-including test for ransac `Aamna Lawrence`_
- Stringing all the things together for the PREP pipeline +tests `Victor Xiang`_
- Finding noisy channels with comparable output to Matlab +tests-including test for ransac `Aamna Lawrence`_
- Finding the appropriate parameters in the MNE notch filter for implementing clean line noise functionality of Eeglab `Aamna Lawrence`_
- Finding the reason for the difference between the Matlab and Pyprep’s output- Probably minor differences in the filter functions and also rounding done by functions like quantile `Victor Xiang`_ and `Aamna Lawrence`_
- Overall debugging `Victor Xiang`_ and `Aamna Lawrence`_

- Robust average referencing + tests, by `Victor Xiang`_ (`#6 <https://github.com/sappelhoff/pyprep/pull/6>`_)
- Removing trend in the EEG data by high pass filtering and local linear regression + tests, by `Aamna Lawrence`_ (`#6 <https://github.com/sappelhoff/pyprep/pull/6>`_)
- Finding noisy channels with comparable output to Matlab +tests-including test for ransac, by `Aamna Lawrence`_ (`#6 <https://github.com/sappelhoff/pyprep/pull/6>`_)
- Stringing all the things together for the PREP pipeline +tests, by `Victor Xiang`_ (`#6 <https://github.com/sappelhoff/pyprep/pull/6>`_)
- Finding noisy channels with comparable output to Matlab +tests-including test for ransac, by `Aamna Lawrence`_ (`#6 <https://github.com/sappelhoff/pyprep/pull/6>`_)
- Finding the appropriate parameters in the MNE notch filter for implementing clean line noise functionality of Eeglab, by `Aamna Lawrence`_ (`#6 <https://github.com/sappelhoff/pyprep/pull/6>`_)
- Finding the reason for the difference between the Matlab and Pyprep’s output- Probably minor differences in the filter functions and also rounding done by functions like quantile, by `Victor Xiang`_ and `Aamna Lawrence`_ (`#6 <https://github.com/sappelhoff/pyprep/pull/6>`_)

Bug
~~~
Expand All @@ -40,8 +38,8 @@ Bug
API
~~~

- Oversaw modularization of PREP pipeline's submodules and a scikit learn style :func:`pyprep.fit` by `Adam Li`_
- Oversaw ChangeLog by `Victor Xiang`_ and `Aamna Lawrence`_ for transitioning pyPrep to Version 0.3.0 by `Adam Li`_
- Oversaw modularization of PREP pipeline's submodules and a scikit learn style :func:`pyprep.fit`, by `Adam Li`_ (`#6 <https://github.com/sappelhoff/pyprep/pull/6>`_)
- Oversaw ChangeLog by `Victor Xiang`_ and `Aamna Lawrence`_ for transitioning pyPrep to Version 0.3.0, by `Adam Li`_ (`#6 <https://github.com/sappelhoff/pyprep/pull/6>`_)

.. _changes_0_2_3:

Expand All @@ -51,7 +49,7 @@ Version 0.2.3
Doc
~~~

- update formatting and docs and fix tags and releases post-hoc by `Stefan Appelhoff`_
- update formatting and docs and fix tags and releases post-hoc, by `Stefan Appelhoff`_

.. _changes_0_2_2:

Expand All @@ -61,7 +59,7 @@ Version 0.2.2
Bug
~~~

- mne epochs index start at 0, not 1 by `Stefan Appelhoff`_ (`3780abb <https://github.com/sappelhoff/pyprep/commit/3780abb922ebb790c74d3e871e2958d87d8c7e23>`_)
- mne epochs index start at 0, not 1, by `Stefan Appelhoff`_ (`3780abb <https://github.com/sappelhoff/pyprep/commit/3780abb922ebb790c74d3e871e2958d87d8c7e23>`_)

.. _changes_0_2_1:

Expand All @@ -71,7 +69,7 @@ Version 0.2.1
Changelog
~~~~~~~~~

- Add :func:`find_bad_epochs` based on the FASTER algorithm by `Stefan Appelhoff`_ (`0fa9c06 <https://github.com/sappelhoff/pyprep/commit/0fa9c065481c4cbaaf83b275f92b16b8807810b5>`_)
- Add :func:`find_bad_epochs` based on the FASTER algorithm, by `Stefan Appelhoff`_ (`0fa9c06 <https://github.com/sappelhoff/pyprep/commit/0fa9c065481c4cbaaf83b275f92b16b8807810b5>`_)


Authors
Expand All @@ -81,8 +79,8 @@ People who contributed to this software (in alphabetical order)
* Stefan Appelhoff
* Aamna Lawrence
* Adam Li
* Victor Xiang
* Yorguin Mantilla
* Victor Xiang

.. _Stefan Appelhoff: http://stefanappelhoff.com/
.. _Aamna Lawrence: https://github.com/AamnaLawrence
Expand Down

0 comments on commit 18e0bf4

Please sign in to comment.