Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to add an argument in find_bad_by_nan_flat() to change FLAT_THRESHOLD ? #142

Closed
nabilalibou opened this issue Feb 6, 2024 · 2 comments · Fixed by #144
Closed
Labels
enhancement New feature or request

Comments

@nabilalibou
Copy link
Contributor

Hello,
Kudo for this amazing package, I love reproducibility and automatisation when processing data.
I observed that some nearly flat channels are not flagged neither by_deviation nor by_nan_flat (something that could be resolved by #83 ?).

Do you think an argument to toy with in find_bad_by_nan_flat() to change FLAT_THRESHOLD would be interesting ?

@sappelhoff
Copy link
Owner

Hi!

Do you think an argument to toy with in find_bad_by_nan_flat() to change FLAT_THRESHOLD would be interesting ?

Sure, that looks like something that could be easily added! Do you want to prepare a pull request for it? Else, I can look into it -- let me know.


solving:

would require much more thought and experimentation, I am afraid

@sappelhoff sappelhoff added the enhancement New feature or request label Feb 7, 2024
@nabilalibou
Copy link
Contributor Author

ok i'll do a PR, i think it will do more or less the trick before #83 is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants