ADD flat_threshold argument in find_bad_by_nan_flat method from NoisyChannels

[nabilalibou]

• PR closes Possible to add an argument in find_bad_by_nan_flat() to change FLAT_THRESHOLD ? #142

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9999839) 98.89% compared to head (ff7f077) 98.89%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   98.89%   98.89%   -0.01%     
==========================================
  Files           7        7              
  Lines         726      725       -1     
==========================================
- Hits          718      717       -1     
  Misses          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sappelhoff]

Looks like a really good start!

Could you please:

• add a section here: https://pyprep.readthedocs.io/en/latest/matlab_differences.html to explain that unlike in MATLAB PREP we allow for editing the threshold (but keep the same default)?
• Add yourself to this file: https://github.com/sappelhoff/pyprep/blob/main/CITATION.cff

[nabilalibou]

Done

[sappelhoff]

wonderful, thanks a lot for your first contribution @nabilalibou!

Here a short note for you for the general pull request process that may help you down the line: https://hynek.me/articles/pull-requests-branch/

[sappelhoff]

just another note @nabilalibou if you have an ORCID account, may you please let me know your ID? And if you don't have an account (yet), I recommend that you get one, it'll always come in handy in a scientific career.

[nabilalibou]

Here a short note for you for the general pull request process that may help you down the line: https://hynek.me/articles/pull-requests-branch/

Thanks for the tips !

just another note @nabilalibou if you have an ORCID account, may you please let me know your ID? And if you don't have an account (yet), I recommend that you get one, it'll always come in handy in a scientific career.

I'm not necessarily aiming for a scientific career but you never know so here's my freshly created orcid: https://orcid.org/0009-0009-5869-9735 (should i add it myself in a future PR ?)

[sappelhoff]

Great, please add it in a new PR! 🎉 makes it easier for other people to find your work :-)