Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always keep EEG data in Volts instead of converting to mV #102

Merged
merged 5 commits into from
Aug 4, 2021

Conversation

a-hurst
Copy link
Collaborator

@a-hurst a-hurst commented Aug 3, 2021

PR Description

This PR removes a bunch of unnecessary conversions back and forth between Volts and mV, likewise changing the units for a few user-facing EEG attributes (e.g. self.EEG_before_interpolation) in PrepPipeline from the EEGLAB standard of mV to the MNE standard of volts.

This should make the API less confusing for people used to working in the MNE world, avoid a bunch of unnecessary large matrix multiplication, and makes some other proposed API changes in #99 easier to implement.

Merge Checklist

  • the PR has been reviewed and all comments are resolved
  • all CI checks pass
  • (if applicable): the PR description includes the phrase closes #<issue-number> to automatically close an issue
  • (if applicable): bug fixes, new features, or API changes are documented in whats_new.rst

@codecov-commenter
Copy link

Codecov Report

Merging #102 (8fe116a) into master (7ad292c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   99.04%   99.04%   -0.01%     
==========================================
  Files           7        7              
  Lines         736      734       -2     
==========================================
- Hits          729      727       -2     
  Misses          7        7              
Impacted Files Coverage Δ
pyprep/prep_pipeline.py 100.00% <100.00%> (ø)
pyprep/reference.py 99.18% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad292c...8fe116a. Read the comment docs.

@sappelhoff sappelhoff merged commit ec44384 into sappelhoff:master Aug 4, 2021
@sappelhoff
Copy link
Owner

Thanks @a-hurst!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants