Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flake8 to pre.commit-config #104

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

joDancker
Copy link
Contributor

@joDancker joDancker commented Aug 15, 2021

PR Description

I have added flake8 to the pre-commit-config file so that the code style is checked automtically before each commit. The PR would close #103

As I am new to GitHub, I hope that I have done everything correctly and did not mess anything up.

Merge Checklist

  • the PR has been reviewed and all comments are resolved
  • all CI checks pass
  • (if applicable): the PR description includes the phrase closes #<issue-number> to automatically close an issue
  • (if applicable): bug fixes, new features, or API changes are documented in whats_new.rst

Copy link
Owner

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The CI complains that you did not add an empty new line at the end of a file, could you add that please? :-)

You can also change the settings in your editor to do it automatically for you, e.g.: https://stackoverflow.com/questions/44704968/visual-studio-code-insert-new-line-at-the-end-of-files

@joDancker
Copy link
Contributor Author

There was also a flake8 issue in one of the example files, which appeared in one of the CI checks. I hope I could split the line as I did with the commit 26303b6.

@codecov-commenter
Copy link

Codecov Report

Merging #104 (26303b6) into master (6c622f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files           7        7           
  Lines         734      734           
=======================================
  Hits          727      727           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c622f3...26303b6. Read the comment docs.

Copy link
Owner

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @joDancker :)

@sappelhoff sappelhoff merged commit 04fbf2e into sappelhoff:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding flake8 to pre-commit-config
3 participants