Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNE-Python 1.0 fixes #114

Merged
merged 7 commits into from
Mar 29, 2022
Merged

MNE-Python 1.0 fixes #114

merged 7 commits into from
Mar 29, 2022

Conversation

sappelhoff
Copy link
Owner

@sappelhoff sappelhoff commented Mar 28, 2022

PR Description

intended to fix #113 eventually. First by adding some CI steps to catch such issues earlier in the future.

@sappelhoff
Copy link
Owner Author

@walkerped I test pyprep against mne-python 1.0 now (and also against new development versions to catch such future issues more quickly) ... however, the tests pass -- so it could be that we don't cover that critical part with our tests.

I pushed what I suspect to be a fix in e945797

could you try to re-install pyprep from this branch and see if it fixes your problem?

This should work:

pip uninstall pyprep
pip install git+https://github.com/sappelhoff/pyprep.git@fix/mne/1.0

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #114 (798fb7b) into master (0f41361) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files           7        7           
  Lines         719      719           
=======================================
  Hits          712      712           
  Misses          7        7           
Impacted Files Coverage Δ
pyprep/prep_pipeline.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f41361...798fb7b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving prep.raw give error " ValueError: Measurement infos are inconsistent for dig"
2 participants