Retain HF noise channels during RANSAC when not bad by any other metric #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Closes #63. This PR modifies NoisyChannels so that channels bad by high-frequency noise (and only by HF-noise) are included in RANSAC predictions, as they are in MATLAB PREP.
The rationale for this (other than lining up more closely with MatPREP's internal logic) is that RANSAC uses a copy of the data that's been lowpass-filtered at 50Hz anyway, so high-frequency noise isn't necessarily automatic grounds for exclusion.
Merge Checklist
closes #<issue-number>to automatically close an issue