Skip RANSAC predictions for channels already confirmed as bad #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
- Coverage 97.15% 97.13% -0.02%
==========================================
Files 7 7
Lines 597 594 -3
==========================================
- Hits 580 577 -3
Misses 17 17
Continue to review full report at Codecov.
|
sappelhoff
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
awesome, a nice low hanging (but somewhat hidden) fruit.
Thanks @a-hurst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Started work on finishing up #66 and ended up noticing this in the process. Essentially, MATLAB PREP doesn't bother to do RANSAC predictions/correlations for channels that have already been flagged as unsuitable for use as RANSAC predictors (i.e., bad by correlation, deviation, or dropout). Instead, those rows in the correlation matrix get filled with ones, so those channels are never "bad-by-RANSAC" (since they're already confirmed bad by something else).
Anyway, this reduces the RAM requirements for channel-wise RANSAC and also ends up simplifying the existing RANSAC code quite a bit (since we no longer need to pass the lists of complete/good channels all the way down to
_get_ransac_predto transform good channel indices to complete channel indices).Merge Checklist
closes #<issue-number>to automatically close an issue