Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle new account creation with same identifiers. #416

Closed
sappenin opened this issue Nov 12, 2019 · 0 comments
Closed

Handle new account creation with same identifiers. #416

sappenin opened this issue Nov 12, 2019 · 0 comments
Assignees
@theotherian
Labels
accounts enhancement
Projects
v0.1.0 Release

Comments

@sappenin
Copy link
Collaborator

If a new account is created with the same AccountId, this should manifest in a 409 (seems to be working). If a new account is created with the same settlement engine id, we should return a valid problem instead of an error 500.

There is an IT (currently ignored) written in AccountSettingsSpringBootTest.java that covers this scenario. Fixing this issue should make that test pass.
@sappenin sappenin added this to To do in v0.1.0 Release via automation Nov 12, 2019
@theotherian theotherian self-assigned this Nov 15, 2019
theotherian added a commit that referenced this issue Nov 15, 2019
@theotherian
respond with 409 when settlement engine id is dupe on new account #416
6d6d0ac 
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
theotherian added a commit that referenced this issue Nov 15, 2019
@theotherian
unit test #416
db7e1f9 
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
theotherian added a commit that referenced this issue Nov 15, 2019
@theotherian
respond with 409 when settlement engine id is dupe on new account #416 (
6e84a02 
#432)

* respond with 409 when settlement engine id is dupe on new account #416

Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>

* unit test #416

Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
@theotherian theotherian moved this from To do to In progress in v0.1.0 Release Nov 15, 2019
v0.1.0 Release automation moved this from In progress to Done Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theotherian theotherian

Labels
accounts enhancement
Projects
No open projects
v0.1.0 Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sappenin @theotherian