Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(events): remove UnknownCommandName, changed UnknownCommand #165

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Feb 7, 2021

No description provided.

@kyranet kyranet requested a review from favna as a code owner February 7, 2021 13:23
@kyranet kyranet requested a review from a team February 7, 2021 13:23
@kyranet kyranet marked this pull request as draft February 7, 2021 13:24
vladfrangu
vladfrangu previously approved these changes Feb 7, 2021
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn you for breaking more code, but lgtm

BREAKING CHANGE: Changed `Events.UnknownCommandName` event arguments to `UnknownCommandNamePayload`.
BREAKING CHANGE: Changed `Events.UnknownCommand` event arguments to `UnknownCommandPayload`.
@kyranet kyranet force-pushed the refactor/remove-unknown-command-name-and-changed-params-to-payload branch from 7704dd5 to a88f50e Compare February 7, 2021 13:27
@kyranet kyranet marked this pull request as ready for review February 7, 2021 13:28
@favna favna requested review from Stitch07 and a team February 7, 2021 13:29
@kyranet kyranet merged commit c3273d1 into main Feb 7, 2021
@kyranet kyranet deleted the refactor/remove-unknown-command-name-and-changed-params-to-payload branch February 7, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants