Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added auto-preconditions #199

Merged
merged 5 commits into from
May 16, 2021
Merged

feat: added auto-preconditions #199

merged 5 commits into from
May 16, 2021

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented May 15, 2021

  • feat(command): added auto-preconditions
  • feat(command): added CommandOptions.nsfw
  • feat(command): added CommandOptions.cooldownBucket
  • feat(command): added CommandOptions.cooldownDuration
  • feat(command): added CommandOptions.runIn
  • feat(identifiers): added Identifiers.PreconditionNewsOnly
  • feat(identifiers): added Identifiers.PreconditionTextOnly
  • BREAKING CHANGE: refactor(command): force array in CommandOptions.preconditions

Note: CommandOptions.permissions has not been added because it's too tied to discord.js, an alternative approach which allows us to go library agnostic will be available later.

@kyranet
feat: added auto-preconditions
4ee516b 
feat(command): added `CommandOptions.nsfw`
feat(command): added `CommandOptions.cooldownBucket`
feat(command): added `CommandOptions.cooldownDuration`
feat(command): added `CommandOptions.runIn`
feat(identifiers): added `Identifiers.PreconditionNewsOnly`
feat(identifiers): added `Identifiers.PreconditionTextOnly`
BREAKING CHANGE: refactor(command): force array in `CommandOptions.preconditions`
@kyranet kyranet requested a review from favna as a code owner May 15, 2021 15:22
@kyranet kyranet requested a review from a team May 15, 2021 15:22
vladfrangu
vladfrangu requested changes May 15, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really not agnostic-ready but LGTM?

src/lib/structures/Command.ts Outdated Show resolved Hide resolved
src/lib/structures/Command.ts Outdated Show resolved Hide resolved
src/lib/structures/Command.ts Outdated Show resolved Hide resolved
PyroTechniac
PyroTechniac previously requested changes May 15, 2021
View reviewed changes
src/lib/structures/Command.ts Show resolved Hide resolved
vladfrangu
vladfrangu previously approved these changes May 15, 2021
View reviewed changes
favna
favna previously approved these changes May 15, 2021
View reviewed changes
@favna favna dismissed stale reviews from vladfrangu and themself via 7dcb57d May 15, 2021 23:23
@favna favna dismissed PyroTechniac’s stale review May 15, 2021 23:23

is question, and answered by @kyranet

@kyranet kyranet merged commit 7e79e15 into main May 16, 2021
@kyranet kyranet deleted the feat/added-auto-preconditions branch May 16, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favna favna favna approved these changes

@vladfrangu vladfrangu vladfrangu left review comments

@PyroTechniac PyroTechniac Awaiting requested review from PyroTechniac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyranet @favna @vladfrangu @PyroTechniac