feat: updated for pieces v3
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
requested changes
Sep 9, 2021
favna
requested changes
Sep 9, 2021
feat(Command): make `fullCategory` not nullable refactor(Command): remove category detection workaround refactor(Command): improved logic for `category` getter refactor(Command): improved logic for `subCategory` getter refactor(Command): improved logic for `parentCategory` getter refactor(Command): strict type `toJSON()` refactor(Listener): strict type `toJSON()` BREAKING CHANGE: Updated `@sapphire/pieces` to `3.0.0` BREAKING CHANGE: Removed `Command#categories`, use `CommandStore#categories` instead
kyranet
force-pushed
the
feat/update-for-pieces-v3
branch
from
caffa5d
to
f1dbcf3
Compare
favna
approved these changes
Sep 9, 2021
vladfrangu
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fullCategorynot nullable.categorygetter.subCategorygetter.parentCategorygetter.toJSON().toJSON().@sapphire/piecesto3.0.0.Command#categories, useCommandStore#categoriesinstead.