Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated dinner form v1 #1046

Merged
merged 9 commits into from May 12, 2020
Merged

Conversation

Jessseee
Copy link
Contributor

@Jessseee Jessseee commented Dec 3, 2019

Adds possibility for board members to add a dinner form link to the homepage that stays open for a given time and is hidden an our after the form has ended.

app/Http/Controllers/DinnerformController.php Outdated Show resolved Hide resolved
app/Http/Controllers/HomeController.php Outdated Show resolved Hide resolved
app/Models/Dinnerform.php Outdated Show resolved Hide resolved
config/hashids.php Outdated Show resolved Hide resolved
resources/views/dinnerform/dinnerform_block.blade.php Outdated Show resolved Hide resolved
resources/views/dinnerform/dinnerform_block.blade.php Outdated Show resolved Hide resolved
resources/views/dinnerform/admin.blade.php Show resolved Hide resolved
app/Models/Dinnerform.php Outdated Show resolved Hide resolved
app/Models/Dinnerform.php Outdated Show resolved Hide resolved
@Jessseee
Copy link
Contributor Author

Closed due to partial implementation complicating further implementation in the future

@Jessseee Jessseee closed this Dec 15, 2019
@jonathanjuursema
Copy link
Member

Closed due to partial implementation complicating further implementation in the future

What's wrong?

@Jessseee
Copy link
Contributor Author

What's wrong?

The migrations made in this pull request complicate changes we want to make in the complete integration of the dinnerform.

@Jessseee Jessseee force-pushed the feature/1023/integrated-dinner-form branch 2 times, most recently from c1bd404 to 583f679 Compare February 13, 2020 11:29
@Jessseee Jessseee force-pushed the feature/1023/integrated-dinner-form branch from 583f679 to 0ef5684 Compare February 13, 2020 17:33
@Jessseee Jessseee removed the request for review from jonathanjuursema February 19, 2020 12:15
Copy link
Member

@JonaMata JonaMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

app/Http/Controllers/DinnerformController.php Outdated Show resolved Hide resolved
app/Http/Controllers/DinnerformController.php Outdated Show resolved Hide resolved
resources/views/dinnerform/dinnerform_block.blade.php Outdated Show resolved Hide resolved
app/Http/Controllers/DinnerformController.php Outdated Show resolved Hide resolved
app/Http/Controllers/DinnerformController.php Outdated Show resolved Hide resolved
app/Http/Controllers/DinnerformController.php Outdated Show resolved Hide resolved
app/Http/Controllers/DinnerformController.php Outdated Show resolved Hide resolved
app/Http/Controllers/DinnerformController.php Outdated Show resolved Hide resolved
Copy link
Member

@jonathanjuursema jonathanjuursema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see almost none of my remarks are visible in the commits you pushed last week. Perhaps you forgot to push one or more commits?

@jonathanjuursema jonathanjuursema self-requested a review May 12, 2020 18:34
Copy link
Member

@jonathanjuursema jonathanjuursema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanjuursema jonathanjuursema merged commit 9a25c94 into master May 12, 2020
@jonathanjuursema jonathanjuursema deleted the feature/1023/integrated-dinner-form branch May 12, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants