New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated dinner form v1 #1046
Conversation
…xternal google form.
resources/views/dinnerform/admin_includes/dinnerform-details.blade.php
Outdated
Show resolved
Hide resolved
resources/views/dinnerform/admin_includes/dinnerform-list.blade.php
Outdated
Show resolved
Hide resolved
resources/views/dinnerform/admin_includes/dinnerform-details.blade.php
Outdated
Show resolved
Hide resolved
Closed due to partial implementation complicating further implementation in the future |
What's wrong? |
The migrations made in this pull request complicate changes we want to make in the complete integration of the dinnerform. |
c1bd404
to
583f679
Compare
583f679
to
0ef5684
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there
database/migrations/2019_11_29_103335_create_dinnerforms_table.php
Outdated
Show resolved
Hide resolved
resources/views/dinnerform/admin_includes/dinnerform-details.blade.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see almost none of my remarks are visible in the commits you pushed last week. Perhaps you forgot to push one or more commits?
resources/views/dinnerform/admin_includes/dinnerform-details.blade.php
Outdated
Show resolved
Hide resolved
…hanjuursema in review of Pull Request. Refs #1046
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds possibility for board members to add a dinner form link to the homepage that stays open for a given time and is hidden an our after the form has ended.