Fix gitdir of linked-worktree #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gitdir of linked-worktree was targeting a static path (e.g. /home/fiveturns/fixtures/main/.git/worktrees/linked-worktree-1) which is breaking tests using dynamic paths.
This was referenced Feb 27, 2020
|
@sbourlon Hey, thanks for fixing that. Can you delete The filename contains the sha-1 hash of the tar archive (before gzip compression). Although it doesn't change the outcome of the tests, it's what I found the existing fixtures to be named after. |
|
Actually, I have some time now to do this. One sec :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gitdir of linked-worktree was targeting a static path
(e.g. /home/fiveturns/fixtures/main/.git/worktrees/linked-worktree-1)
which is breaking tests using dynamic paths.