Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac support #14

Merged
merged 10 commits into from May 25, 2021
Merged

Conversation

MaddTheSane
Copy link
Contributor

Initial Mac support.
Based on the work of @almeath and @kode54 at https://github.com/PCemOnMac/PCemV17macOS

@MaddTheSane MaddTheSane marked this pull request as ready for review May 19, 2021 22:24
@sarah-walker-pcem
Copy link
Owner

Changes to SDL #include breaks the Windows build.

@Shambler2
Copy link

Have done some testing on the other project when they were attempting to add M1 support on macOS - one of the changes needed for that support doesn't appear to be in this pull request, configure.ac requires some minor changes to correctly identify the M1 as an arm CPU:
AC_MSG_CHECKING([for cpu]) case "${host_cpu}" in arm) CPU=arm64 # MacOS has "arm" in the host string AC_MSG_RESULT(${host_cpu}) ;;

Go back to using SDL2 in front of SDL2 header includes.
@MaddTheSane
Copy link
Contributor Author

I know.
I don't want to use that override due to the fact that it might confuse checks on 32-bit ARM machines.
The check will need to be more advanced than @almeath's way.
I got around this by passing --build=aarch64-apple-darwin20.4.0 to configure. This isn't ideal, I know.

@Shambler2
Copy link

Yep figured that might have been the case :)

Not ideal but thanks for the workaround for now

@sarah-walker-pcem sarah-walker-pcem merged commit 5da96ac into sarah-walker-pcem:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants