Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate projections & demonstrate its effect #1

Merged
merged 1 commit into from May 26, 2022
Merged

Incorporate projections & demonstrate its effect #1

merged 1 commit into from May 26, 2022

Conversation

UInt2048
Copy link
Contributor

This is a screenshot of an instance of this PR's code running showing the level information section, thanks to the new version 1.4.0 of WKStats Projections Page being incorporated as a module.

Unfortunately, this required minor modification to your js/mainWkof.js due to the upgrade to strict mode imposed by the use of an ES6 module. (Since you were already using code with ES8 features in that file, browser support will not be affected.)

image

* Projections Demo (#1)

* Create projections.js

* Add projection element

* Trigger projections event

* Try to use projections as a package

* Continue trying this package thing

* Add module type to script

* JSHint suggested fixes since we're in strict mode

* Whoops - accidentally broke two good ones

* Try another module approach

* Make this projections script a cool object

* Funny curly braces

* Allow projections to use unaltered item data

* Replace this use with P due to arrow functions

* Change hide past to show past levels
@saraqael-m saraqael-m merged commit 2ab5a61 into saraqael-m:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants