Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules with missing rules from updated pluralize js library #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jerome2606
Copy link

I made the comparison with the actual master branch on the JS pluralize library to update all the changes (not much at the end)

@sarathkcm
Copy link
Owner

Hi @Jerome2606,

Thank you for taking the time to contribute - appreciate it.

Could you please provide the commit ID up to which you have synchronized the rules? Asking because I could find some extra rules in the latest master branch of the original library.

Thanks & Regards
Sarath

@sarathkcm
Copy link
Owner

I'll just outline what I observed.

  1. The singular rule - [/(dg|ss|ois|lk|ok|wn|mb|th|ch|ec|oal|is|ck|ix|sser|ts|wb)ies$/i, '$1ie'], is missing .
  2. 'species' is removed from uncountables in the original library.
  3. Lots of tests added to test singular words ending in 'ie'.

Kindly update these if you were going for complete sync with the master branch of the original library.

Otherwise no worries, please just update the commit ID up to which your changes reflect in the Readme file, and as long as your changes cover all the changes & the tests up to that commit ID - I'll be happy to merge this PR.

Thanks & Regards
Sarath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants