-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How is this lib maintained? #5
Comments
I'm worried about this too, this package is a temporarily solution. have you found any alternatives for this? @zedtux |
Long story short @mopx, I ended implementing it using raw WebSockets. I'm building a React Native application, using a Rails 4.x backend application which uses a very old version of ActionCable. In the context of React-Native, I found the react-native-actioncable package which is doing exactly what should be done in this package : Importing the real actioncable JavaScript package and adapts it for RN. I wanted to check this repo forks, but as Github removed their nice fork map view, I can't anymore, so let's assume nobody did it as of now, this repo should be forked, the actioncable copy removed, and actioncable should be added to the I hope this gives you some good input for your @mopx, and sorry to not have an easy solution 😞. |
thanks for the pointers @zedtux ! BTW you can still access the fork map by adding /network after the repo url. But there's nothing relevant added. e.g. https://github.com/zekedran/action-cable-react-jwt/network |
Oh great, thank you @mopx. 👍 |
I made a PR on the Rails project to implement adding sub protocols to ActionCable so that this library will not be needed in the future, and it has been merged ! 🤩 |
Hi @zedtux, thanks for the pull request in the rails library, this was probably long awaited by many users! I initially copied the compiled code to make quick changes for use in my app, it ended up staying that way being used by many. Anyway, I was checking to see if I can directly use |
Well, the You can use the github URL as source in your |
As far as I can see from the source code, you're not importing the actioncable library, but you have a copy of it in your lib.
This means, tomorrow there is a new version of
actioncable
, you'll have to update you code with this update, isn't It?What version of actioncable do you have right now?
The text was updated successfully, but these errors were encountered: