Delimiter Added in case of Number format #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ravikant-paudel
commented
Dec 15, 2021
•
ravikant-paudel
commented
sarbagyastha
requested changes
Dec 17, 2021
example/main.dart
Outdated
Comment on lines
42
to
56
| var currencyFormatWithDelimiterAndDecimal = NepaliNumberFormat( | ||
| decimalDigits: 2, | ||
| ); | ||
| var currencyFormatWithDelimiter = NepaliNumberFormat( | ||
| symbol: 'Rs.', | ||
| ); | ||
| var currencyFormatWithNoDelimiter = NepaliNumberFormat( | ||
| symbol: 'Rs.', | ||
| delimiter: '', | ||
| ); | ||
| var delimiterWithDecimal = NepaliNumberFormat( | ||
| decimalDigits: 2, | ||
| delimiter: '', | ||
| ); | ||
|
|
There was a problem hiding this comment.
They don't seem to currency format as monetary is false by default. Please rename it to numberFormat.
Also, example for on with delimiter and another without it should be enough.
example/main.dart
Outdated
Comment on lines
74
to
86
| heading('With Empty Delimiter'); | ||
| print('1234 -> ${currencyFormatWithNoDelimiter.format(1234)}'); | ||
| print('12345 -> ${currencyFormatWithNoDelimiter.format(12345)}'); | ||
| print('123456 -> ${currencyFormatWithNoDelimiter.format(123456)}'); | ||
| print('123456789.6548 -> ${delimiterWithDecimal.format(123456789.6548)}'); | ||
|
|
||
| heading('With Delimiter'); | ||
| print('1234 -> ${currencyFormatWithDelimiter.format(1234)}'); | ||
| print('12345 -> ${currencyFormatWithDelimiter.format(12345)}'); | ||
| print('123456 -> ${currencyFormatWithDelimiter.format(123456)}'); | ||
| print( | ||
| '1234567.891 -> ${currencyFormatWithDelimiterAndDecimal.format(1234567.891)}'); | ||
|
|
There was a problem hiding this comment.
only two types of example should be enough
lib/src/nepali_number_format.dart
Outdated
| /// 2000(delimiter = '') -> 2000 | ||
| /// 2000(delimiter = '.') -> 2.000 | ||
| /// | ||
| /// Default value ','. |
lib/src/nepali_number_format.dart
Outdated
| @@ -229,15 +239,15 @@ class NepaliNumberFormat { | |||
| if (hideDecimal) { | |||
| return '${localizedNum[0]},${localizedNum.substring(1)}'; | |||
There was a problem hiding this comment.
You missed adding delimiter here.
The case can be verified by setting includeDecimalIfZero: false and having number with all zeros after decimal point.
test/nepali_number_format_test.dart
Outdated
Comment on lines
128
to
156
| group('hide comma tests:', () { | ||
| test( | ||
| 'default is english', | ||
| () => expect(NepaliNumberFormat(delimiter: '').format(1234), '1234'), | ||
| ); | ||
| test( | ||
| 'formats in nepali', | ||
| () => expect( | ||
| NepaliNumberFormat(language: Language.nepali, delimiter: '') | ||
| .format(1234), | ||
| '१२३४', | ||
| ), | ||
| ); | ||
| }); | ||
|
|
||
| group('hide comma tests:', () { | ||
| test( | ||
| 'default is english', | ||
| () => expect(NepaliNumberFormat(delimiter: '*').format(1234), '1*234'), | ||
| ); | ||
| test( | ||
| 'formats in nepali', | ||
| () => expect( | ||
| NepaliNumberFormat(language: Language.nepali, delimiter: '*') | ||
| .format(1234), | ||
| '१*२३४', | ||
| ), | ||
| ); | ||
| }); |
There was a problem hiding this comment.
The group and it's test has same name, but it's doing different things.
ravikant-paudel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.