Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Added ignore translation list #8

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[Feature] Added ignore translation list #8

wants to merge 3 commits into from

Conversation

abnormalbbk
Copy link

image
image

sarbagyastha
sarbagyastha requested changes Aug 29, 2022
View reviewed changes
Copy link
Owner

@sarbagyastha sarbagyastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I have added few comments.

lib/src/nepali_unicode.dart
@@ -195,10 +207,12 @@ class NepaliUnicode {
}

static void _replace(x, y) {
if (_ignoreList.contains(x)) return;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed ?

lib/src/nepali_unicode.dart
static String convert(
String text, {
bool live = false,
List<String> ignoreList = const [],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of using a Regex instead ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's an good idea. let me make the neccessary changes

@sarbagyastha sarbagyastha changed the base branch from master to develop August 29, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarbagyastha sarbagyastha sarbagyastha requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abnormalbbk @sarbagyastha