Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change in minor version #83

Closed
ljharb opened this issue May 7, 2016 · 3 comments · Fixed by #84
Closed

Breaking change in minor version #83

ljharb opened this issue May 7, 2016 · 3 comments · Fixed by #84

Comments

@ljharb
Copy link
Collaborator

ljharb commented May 7, 2016 •
edited
Loading

So, first, 93a68b6 is a breaking change, and should not have been released as a minor version.

Second, it is failing for me when run as a local utility. Using npm run-scripts, eslint-find-rules can be invoked directly, since npm puts it in the PATH - so your method of determining "is global" is flawed.
This was referenced May 7, 2016
Closed
Merged
@ljharb ljharb changed the title Breaking change in patch version Breaking change in minor version May 7, 2016
ljharb added a commit to ljharb/eslint-config that referenced this issue May 7, 2016
@ljharb
[Dev Deps] update eslint-find-rules, nsp
0c6791e 
- Lock `eslint-find-rules` to 1.8.x due to sarbbottam/eslint-find-rules#83
@ljharb
Copy link
Collaborator Author

ljharb commented May 7, 2016

ping @sarbbottam @kentcdodds

ljharb added a commit to ljharb/javascript that referenced this issue May 7, 2016
@ljharb
[eslint config] [base] update eslint-plugin-import
ee7315a 
Locking `eslint-find-rules` to `v1.8` due to sarbbottam/eslint-find-rules#83
@sarbbottam
Copy link
Owner

@ljharb extremely sorry about it. We use semantic-release, which looks for BREAKING CHANGE in the commit message to release a major version. Making a re-release reverting this change.

sarbbottam added a commit that referenced this issue May 7, 2016
@sarbbottam
fix(version): skip is-global check
d76e888 
id-global check should not have been part of minor release

fixed #83
sarbbottam added a commit that referenced this issue May 7, 2016
@sarbbottam
fix(version): skip is-global check
3394240 
is-global check should not have been part of minor release

fixed #83
@sarbbottam sarbbottam mentioned this issue May 7, 2016
Merged
sarbbottam added a commit that referenced this issue May 7, 2016
@sarbbottam
fix(version): skip is-global check (#84)
2af3828 
is-global check should not have been part of minor release

fixed #83
@sarbbottam sarbbottam mentioned this issue May 7, 2016
Closed
@ljharb
Copy link
Collaborator Author

ljharb commented May 7, 2016

Thanks!

ljharb added a commit to ljharb/eslint-config that referenced this issue May 8, 2016
@ljharb
[Dev Deps] update eslint-find-rules
3ac73eb 
Per issue fixed in sarbbottam/eslint-find-rules#83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(version): skip is-global check sarbbottam/eslint-find-rules
2 participants
@ljharb @sarbbottam