docs(readme): updated description, badges #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
| @@ -29,23 +33,27 @@ The intended usage is as an npm script: | |||
| { | |||
| ... | |||
| "scripts": { | |||
| "find-new-rules": "eslint-find-new-rules path/to/eslint-config" | |||
| "eslint-find-option-rules": "eslint-rule-finder --option path/to/eslint-config" | |||
There was a problem hiding this comment.
--option looks like an actual option to specify as argument to me.
Personally I'd prefer if this could be an example with an actual command and later on (L42-45) we could simply state eslint-rule-finder [option] <file> or sth. like that (possibly just the way the ESLint cli does it).
|
Other than that single note, it looks good to me! 👍 |
and added acknowledgement fixed #5
sarbbottam
force-pushed
the
documentation
branch
from
8aa98bb
to
3e0c464
Compare
|
Addressed the review comment, please take another look and merge if it looks fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and added acknowledgement
fixed #5
@ta2edchimp please review.