fix(exit-code): determination logic #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #199 diff @@
====================================
Files 9 9
Lines 228 231 +3
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 228 231 +3
Misses 0 0
Partials 0 0
|
|
@ta2edchimp @ljharb please review when you get time. This should get merged ASAP. |
ljharb
requested changes
Oct 31, 2016
| // if --no-error is passed argv.error will be false | ||
| // if -n was passed it would set argv.error to false | ||
| if (argv.n) { | ||
| argv.error = false |
There was a problem hiding this comment.
you may prefer not to mutate argv here - ie, const showError = argv.error && !argv.n; and then const processExitCode = argv.u && showError ? 1 : 0;?
There was a problem hiding this comment.
I originally did it in that way, but though for this scope it was not required. But good practice is always good practice. Will update it accordingly.
I named the variable as errorOut.
argv.error is true by default if --no-error is passed argv.error will be false if -n was passed it would set argv.error to false
sarbbottam
force-pushed
the
fix/error-out
branch
from
e532a6b
to
a279253
Compare
|
Please find the test at https://github.com/sarbbottam/eslint-find-rules/blob/master/test/bin/find.js#L100-L112. |
ljharb
approved these changes
Oct 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
existing logic to determine exit code was not correct.
argv.error is true by default
if --no-error is passed argv.error will be false
if -n was passed it would set argv.error to false
fixes #194
@ljharb @ta2edchimp
Please excuse me for the plethora of PRs over the weekend. Sorry about it.
Hopefully, this is the last one.