Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): implement sorting of config diff object #56

Merged
merged 1 commit into from
Apr 20, 2016
Merged

feat(lib): implement sorting of config diff object #56

merged 1 commit into from
Apr 20, 2016

Conversation

ta2edchimp
Copy link
Collaborator

Relates to #50

@ta2edchimp ta2edchimp changed the title Pr/sort rules feat(lib): implement sorting of config diff object Apr 19, 2016
@ta2edchimp ta2edchimp mentioned this pull request Apr 19, 2016
Closed
@codecov-io
Copy link

Current coverage is 100.00%

Merging #56 into master will not affect coverage as of 1afcc7e

@@            master     #56   diff @@
======================================
  Files            6       6       
  Stmts          140     150    +10
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            140     150    +10
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 1afcc7e

Powered by Codecov. Updated on successful CI builds.

@ta2edchimp
Copy link
Collaborator Author

Will rebase and push again.

sarbbottam
sarbbottam reviewed Apr 19, 2016
View reviewed changes
src/lib/sort-rules.js
return rules.sort(sortAlphabetically)
}

function transformIntoSortedRulesArray(allRulesArray) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the name allRulesArray is not semantic, its and object, may be you want to keep it rules

@sarbbottam
Copy link
Owner

👍 after rebase and typo fix!

@sarbbottam sarbbottam closed this Apr 19, 2016
@sarbbottam sarbbottam reopened this Apr 19, 2016
@sarbbottam
Copy link
Owner

My bad, clicked the wrong button by mistake.

@ta2edchimp ta2edchimp merged commit dc6994d into sarbbottam:master Apr 20, 2016
@ta2edchimp
Copy link
Collaborator Author

Merged, as coordinated with @sarbbottam

@ta2edchimp ta2edchimp deleted the pr/sort-rules branch April 20, 2016 09:29
@snyk-bot snyk-bot mentioned this pull request Sep 17, 2021
Open
@ta2edchimp ta2edchimp mentioned this pull request May 20, 2022
Open
@ta2edchimp ta2edchimp mentioned this pull request Sep 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ta2edchimp @codecov-io @sarbbottam